NullPointerException in PresenceCollectorRepository (#95)

Wojciech Kapcia (Tigase) opened 5 years ago

[2020-04-13 11:32:58:758] [SEVERE  ] [           in_5-pubsub ] StanzaProcessor.processPacket()  : null when processing from=sess-man@ip-10-0-14-225.us-west-2.compute.internal, to=pubsub@ip-10-0-14-225.us-west-2.compute.internal, DATA=[presence to=&quot;…@tigase.org&quot; type=&quot;unavailable&quot; from=&quot;…@jabber.org&quot; xmlns=&quot;jabber:client&quot;][x xmlns=&quot;vcard-temp:x:update&quot;][photo]4302224…ba79c72920cf[/photo][/x][delay xmlns=&quot;urn:xmpp:delay&quot; stamp=&quot;2020-04-12T02:21:43Z&quot; from=&quot;jabber.org&quot;/][/presence], SIZE=278, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=ADMIN, TYPE=unavailable, STABLE_ID=null
java.lang.NullPointerException
	at tigase.pubsub.repository.PresenceCollectorRepository$Entries.remove(PresenceCollectorRepository.java:156)
	at tigase.pubsub.repository.PresenceCollectorRepository.remove(PresenceCollectorRepository.java:128)
	at tigase.pubsub.cluster.PresenceCollectorRepositoryClustered.remove(SourceFile:41)
	at tigase.pubsub.modules.PresenceCollectorModule.removeJid(PresenceCollectorModule.java:220)
	at tigase.pubsub.modules.PresenceCollectorModule.process(PresenceCollectorModule.java:173)
	at tigase.component.modules.StanzaProcessor.process(StanzaProcessor.java:164)
	at tigase.component.modules.StanzaProcessor.processPacket(StanzaProcessor.java:85)
	at tigase.component.AbstractKernelBasedComponent.processPacket(AbstractKernelBasedComponent.java:81)
	at tigase.pubsub.PubSubComponent.processPacket(PubSubComponent.java:191)
	at tigase.pubsub.cluster.PubSubComponentClustered.processPacket(SourceFile:183)
	at tigase.server.AbstractMessageReceiver$QueueListener.run(AbstractMessageReceiver.java:1401)

Duplicate
- NPE when presence is sent from bare JID (#96) In QA

Activities

Wojciech Kapcia (Tigase) commented 5 years ago

Full stanza:

<presence to="kobit@tigase.org" type="unavailable" from="stpeter@jabber.org" xmlns="jabber:client">
    <x xmlns="vcard-temp:x:update">
        <photo>43022249bf93637a75c73513edb8ba79c72920cf</photo>
    </x>
    <delay xmlns="urn:xmpp:delay" stamp="2020-04-12T02:21:43Z" from="jabber.org"/>
</presence>

Andrzej Wójcik (Tigase) commented 5 years ago

I'll take care of that as I've solved this issue in a newer version of PubSub.
Andrzej Wójcik (Tigase) commented 5 years ago

The issue was in PresenceCollectorRepository class which was introduced in the MIX branch, so it will not be a part of the 8.1.0 release.

That issue was fixed in #issue #96 (most likely this was created for 8.1.0 while the issue existed only in the MIX branch).
Login to comment

Type	Bug
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-pubsub#95