Projects tigase _server server-core Issues #978
Improve VHost configuration / extending (#978)
Closed
wojciech.kapcia@tigase.net opened 6 years ago

Currently handling VHost configuration is a bit cumbersome, it should be possible to:

  • relatively easy extend base configuration options;
    • they should persist even if the code adding them is disabled (i.e. temporarily disabling bean should not remove it's configuration)
  • provide global configuration;
  • allow, in VHost configuration select global configuration or configure particular value.

--

  • in dev guide - how to extend VHost configuration
  • in admin guide - how to configure defaults for VHost
Andrzej Wójcik (Tigase) commented 5 years ago

I've created new API for extending VHost which is more flexible and efficient. At the same time, I've upgraded all existing usage of the old API which we had in our code and added migration of storage data format during save of VHost by the ​new version of Tigase XMPP Server. At the same time I've adjusted TTS-NG to match changes in the adhoc command field names.

wojciech.kapcia@tigase.net commented 5 years ago

Looks good, however it would be nice to include in documentation:

  • in dev guide - how to extend VHost configuration
  • in admin guide - how to configure defaults for VHost
wojciech.kapcia@tigase.net commented 5 years ago

Actually there is a problem (came up with #ttsng-37) :

<stream:features>
<sm xmlns="urn:xmpp:sm:3"/>
<register xmlns="http://jabber.org/features/iq-register"/>
<mechanisms xmlns="urn:ietf:params:xml:ns:xmpp-sasl"/>
<ver xmlns="urn:xmpp:features:rosterver"/>
<sub xmlns="urn:xmpp:features:pre-approval"/>
<starttls xmlns="urn:ietf:params:xml:ns:xmpp-tls">
<required/>
</starttls>
<compression xmlns="http://jabber.org/features/compress">
<method>zlib</method>
</compression>
</stream:features>

I.e. SASL mechanism are not correctly populated (fresh installation without any mechanism configured). This most likely touches on the (missing) point: "allow, in VHost configuration select global configuration or configure particular value."

Andrzej Wójcik (Tigase) commented 5 years ago

Actually,​ the issue from #ttsng-37 has nothing to do with this change.

wojciech.kapcia@tigase.net commented 5 years ago

re-opening due to missing documentation (see updated and previous comment)

Andrzej Wójcik (Tigase) commented 5 years ago

@wojtek I've made changes to the server and message archive to make them work and use defaults. I've done so in separate branch named issue #978 as I'm not sure if it is the final design for this feature. Please review those changes and get back to me with some feedback. If it will be ok, I'll then merge changes to the master branch.

wojciech.kapcia@tigase.net commented 5 years ago

I checked the implementation and documentation and it looks good.

Andrzej Wójcik (Tigase) commented 5 years ago

@wojtek Changes were merged to master branch. Closing this task.

Referenced from commit 12 months ago
issue 1 of 1
Type
New Feature
Priority
Blocker
Assignee
RedmineID
8269
Version
tigase-server-8.1.0
Spent time
41h 45m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#978
Please wait...
Page is in error, reload to recover