Improve Statistics memory usage (#684)

Wojciech Kapcia (Tigase) opened 9 years ago

Due Date
2016-06-23

As stated in #3248#note-19:

statistics labels are not interned hence resulting in thousands of duplicated strings:
numeric values are hold as strings (different data set):

Wojciech Kapcia (Tigase) commented 9 years ago

Applied in changeset commit:tigase-server|6201aaf9.
Artur Hefczyc commented 9 years ago

Have you tested it to see how much improvements did we get from this?
Wojciech Kapcia (Tigase) commented 9 years ago

Not that much - from roughly 3 minutes test (with interval of 1s - roughly 180 items and only MUC and PubSub - metrics are bumped significantly as each component has a lot of default statistics) the memory usage dropped roughly 10MB; I expect that the drop will be more significant for installations with enabled history for a longer period - by default we enable it for 6h (2200 items), so in such case we could save roughly 100-150MB. On bigger installations this may not be much, but sometimes when folks were testing Tigase they were running out of memory, especially with more components enabled.
Wojciech Kapcia (Tigase) commented 9 years ago

Completely separate thing is the size of statistics itself, but that wasn't clue of this ticket.
Login to comment

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#684