Return error if there is listener being added to event which is not thrown (#629)

Andrzej Wójcik (Tigase) opened 9 years ago

Due Date
2016-06-29

Right now it is possible to register in event bus to listen for event which may not be fired as ie. it is not implemented in this version - support added in future version but someone may try register. In this case now it will not know that there is no such event.

I think we should add check so that in this case error should be returned to user that there is no such event.

I do not think this is important at this point but before release of version 7.2.0, I think it may be good idea to add this feature.

Parent Issue
- Improve EventBus implementation (#622) Closed

Activities

Artur Hefczyc commented 9 years ago

Good idea. Who is the best person to work on this, you or Bartosz? Please reassign.
Bartosz Małkowski commented 9 years ago

As we discussed, it is hard to check it during registration listener, because it is possible that something want to listener for some events but event emiter may not be installed at all.

So I added event registration and EventBus may (configurable) throw exception in case of fire unknown event.
Andrzej Wójcik (Tigase) commented 9 years ago

I think this is all we need, however I would suggest to add entry to log wtih FINEST level if there is no event for particular name, even if check is disabled.

It may help during analysis of possible issues, ie. when event name would change.
Andrzej Wójcik (Tigase) commented 9 years ago

I added this log entry just to close this task as higher priority task was waiting for this and this is long overdue.
Login to comment

Type	Task
Priority	Minor
Assignee	Bartosz Małkowski
RedmineID	3822
Version	tigase-server-8.0.0
Spent time	0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#629