Projects tigase _server server-core Issues #481
Fixes user's roster on Tigase cluster (Admin UI) (#481)
Eric Dziewa opened 10 years ago
Due Date
2015-09-29

Disconnects the user from the server.

Successfully adds roster item as above.

Trying to delete, again knocks the user offline, and instead of deleting creates a duplicate item:

"/><contact preped="simple" subs="both" weight="1.0" last-seen="1000" name="makebelieveuser" activity="1.0" jid="makebelieveuser@server.com
"/><contact preped="simple" subs="both" weight="1.0" last-seen="1000" name="makebelieveuser" activity="1.0" jid="makebelieveuser@server.com
Daniel Wisnewski commented 9 years ago

Add item works after disconnecting user. Remove item disconnects user but yields this message

User: admin@tpub.xmpp-test.net/Psi is online, disconnected.

User: admin@tpub.xmpp-test.net is offline, updating database only

Buddy: deleteme@tpub.xmpp-test.net already in the roster, skipping

Item is not removed

Andrzej Wójcik (Tigase) commented 9 years ago

This should work ok now as addition of entry worked OK and in task #3096 I fixed issue responsible for not removing buddy from roster.

Daniel Wisnewski commented 9 years ago

Remove user1 from admin's roster

Removing one user yields following result:

User: admin@domain.org/laptop is online, disconnected.

User: admin@domain.org is offline, updating database only

Buddy: user1@domain.org removed

Admin is kicked, and user1 is removed from his list. Privilege from for user 1 is also revoked, not receiving presence stanzas.

Multiple users:

users separated by comma, same behavior as above, only first user removed.

users separated by comma space, same behavior as above, only first user removed.

users separated by semicolon, same behavior as above, only first user removed.

users separated by new line, admin is kicked, no rosters affected.

Andrzej Wójcik (Tigase) commented 9 years ago

I fixed passing mulitple items - each should be sent is separate line - new line char is separator

Daniel Wisnewski commented 9 years ago

Multi-line works better now, still left with one issue:

Remove multiple users from admin@domain.com roster

admin@domain.com kicked

user1@domain.com, user2@domain.com removed from roster

user1 and user2 privilege to see admin status is revoked.

behaviour is same for single and multi-line removes. Behaviour is same for webUI.

Andrzej Wójcik (Tigase) commented 9 years ago

But what is wrong here?

Daniel Wisnewski commented 9 years ago

Fix user's roster (remove) does not revoke privileges for users to see admin, after users are removed from admin, only affected roster is admin@domain.com.

Fix user's roster on Cluster affects all rosters, removes the requested entries, but revokes privileges from admin to users, which does not mirror Fix user's roster behaviour.

If the change in behaviour is desirable, I would recommend a notification on the page as it does more than the script title suggests.

Andrzej Wójcik (Tigase) commented 9 years ago

I changed RosterFixer to send to removed user to properly notify user that is was removed from roster when user from which roster it is being removed was online.

Daniel Wisnewski commented 9 years ago

works OK

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
3097
Version
tigase-server-7.1.0
Spent time
12h
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#481
Please wait...
Page is in error, reload to recover