javadoc is missing from tigase-server distribution packages (#1195)

wojciech.kapcia@tigase.net opened 4 years ago

No description

wojciech.kapcia@tigase.net commented 4 years ago

Migrating build chain to JDK11 (#issue #1107) resulted in maven-javadoc-plugin to throw errors:

org.apache.maven.reporting.MavenReportException:
Exit code: 1 - /Users/wojtek/dev/tigase/tigase-server-distribution/target/distro-javadoc-sources/tigase-extras-mdns-2.1.0-sources/MDnsComponent.java:19: error: package tigase.http does not exist
import tigase.http.AbstractHttpServer;
                  ^
/Users/wojtek/dev/tigase/tigase-server-distribution/target/distro-javadoc-sources/tigase-extras-mdns-2.1.0-sources/MDnsComponent.java:20: error: package tigase.http does not exist
import tigase.http.HttpMessageReceiver;
                  ^
/Users/wojtek/dev/tigase/tigase-server-distribution/target/distro-javadoc-sources/tigase-extras-mdns-2.1.0-sources/MDnsComponent.java:39: error: package javax.jmdns does not exist
import javax.jmdns.JmDNS;
                  ^
/Users/wojtek/dev/tigase/tigase-server-distribution/target/distro-javadoc-sources/tigase-extras-mdns-2.1.0-sources/MDnsComponent.java:40: error: package javax.jmdns does not exist
import javax.jmdns.NetworkTopologyDiscovery;
                  ^
/Users/wojtek/dev/tigase/tigase-server-distribution/target/distro-javadoc-sources/tigase-extras-mdns-2.1.0-sources/MDnsComponent.java:41: error: package javax.jmdns does not exist
import javax.jmdns.ServiceInfo;
                  ^
/Users/wojtek/dev/tigase/tigase-server-distribution/target/distro-javadoc-sources/tigase-extras-mdns-2.1.0-sources/MDnsComponent.java:347: error: package JmDNS does not exist
	private class JmDNSItem implements JmDNS.Delegate {
	                                        ^
/Users/wojtek/dev/tigase/tigase-server-distribution/target/distro-javadoc-sources/tigase-extras-mdns-2.1.0-sources/MDnsComponent.java:69: error: cannot find symbol
	private Map<String, List<ServiceInfo>> servicesPerComponent = new ConcurrentHashMap<>();
	                         ^

I found an issue in plugin bugtrack (https://issues.apache.org/jira/browse/MJAVADOC-620) which says that the issue should be fixed in 3.2.0 version of the plugin, however bumping it's version didn't solve it.

I tried various changes to build configuration but the problem with resolving dependencies remained. Switching back to JDK8 "resolved" the issue but that's not a solution. I'll prepare minimal test-case and submit bug to maven-javadoc-plugin bugtrack.

wojciech.kapcia@tigase.net commented 4 years ago

There were problems with our projects configuration caused by bump to use JDK11 (#issue #1107), which generated errors but it was a bug in javadoc tools itself (and hence, errors were configured to be ignored). However, addressing it instead of hiding is the right thing: I tried using suggested configuration denoting the sources as version 8 (<source>8</source>) but it didn't work. It turns out that configuring release property for maven compiler also influence javadoc plugin so it had to be un-set in said plugin. In addition, some dependencies (extras, workgroup, socks5, stun) were referencing older version of tigase-server, tigase-http-api which for some reason were examined when building the javadocs (and caused errors).

Referenced from commit 1 year ago

Issue #1195 - changes in default values

Andrzej Wójcik committed 1 decade ago

415fb959

Referenced from commit 1 year ago

Issue #1195 - replaced Timer with ScheduledExecutorService

Andrzej Wójcik committed 1 decade ago

256431e9

Type	Bug
Priority	Normal
Assignee	wojciech.kapcia@tigase.net
Version	tigase-server-8.2.0
Spent time	8h