Fix errors in TTS-NG tests after merges (#54)
Closed
Andrzej Wójcik (Tigase) opened 4 years ago

Fix errors in TTS-NG tests after merges as we have quite a lot of them

wojciech.kapcia@tigase.net commented 4 years ago

It looks like one test is failing constantly for all databases:

  • Discovery of nodes with RSM (only on TC, works fine locally..)

In addition, for Derby and Mongo this one also seems to be failing consistently:

  • MAM: Support for XEP-0313 for PubSub - #4733

And only for Derby:

  • XEP-0136 - Message Archiving - Tags and Contains;

I played a bit with the first one on the assumption that something was interfering and after tweaking a bit the test to make the node-names more unique it seems to be correct assumption:

<iq id="f5YxrcGxfKCJO7BqUOU6mMX" to="pubsub_rsm_bsta50208@test-domain.com/1371991537-tigase-230" xmlns="jabber:client"
    type="result" from="pubsub.test-domain.com">
    <query xmlns="http://jabber.org/protocol/disco#items">
        <item node="test" name="test" jid="pubsub.test-domain.com"/>
        <item node="collection-4ee73b44-941f-4695-aba6-dd3c3c262bdd" name="collection-4ee73b44-941f-4695-aba6-dd3c3c262bdd" jid="pubsub.test-domain.com"/>
        <item node="node-001__dcb73f7b-708b-4aff-b1d8-af87ccf70ad7" name="Node 001__dcb73f7b-708b-4aff-b1d8-af87ccf70ad7" jid="pubsub.test-domain.com"/>
        <item node="node-002__09561031-ff02-4bc0-b3b1-ea62eab90b3f" name="Node 002__09561031-ff02-4bc0-b3b1-ea62eab90b3f" jid="pubsub.test-domain.com"/>
        <item node="node-003__bfd26ea3-e52c-4cbd-95b8-6db0fdd24690" name="Node 003__bfd26ea3-e52c-4cbd-95b8-6db0fdd24690" jid="pubsub.test-domain.com"/>
        <item node="node-004__b88b859a-5009-4e1a-9a91-92114b4735db" name="Node 004__b88b859a-5009-4e1a-9a91-92114b4735db" jid="pubsub.test-domain.com"/>
        <item node="node-005__b6135f6d-6746-4330-9d9b-45c9fdc7a454" name="Node 005__b6135f6d-6746-4330-9d9b-45c9fdc7a454" jid="pubsub.test-domain.com"/>
        <item node="node-006__b7d22848-bc94-46ee-8a99-f9951636734a" name="Node 006__b7d22848-bc94-46ee-8a99-f9951636734a" jid="pubsub.test-domain.com"/>
        <item node="node-007__f75f71c1-8edf-4e38-a0a5-fbaee4db5b81" name="Node 007__f75f71c1-8edf-4e38-a0a5-fbaee4db5b81" jid="pubsub.test-domain.com"/>
        <item node="node-008__eacfc985-3879-4506-9c2c-e1568fda7daf" name="Node 008__eacfc985-3879-4506-9c2c-e1568fda7daf" jid="pubsub.test-domain.com"/>
        <item node="node-009__354edafb-64a1-4d9d-88c7-e4d9c1d2f6f5" name="Node 009__354edafb-64a1-4d9d-88c7-e4d9c1d2f6f5" jid="pubsub.test-domain.com"/>
        <item node="node-010__bc62ae8f-68e5-4c87-810d-40a0140fad78" name="Node 010__bc62ae8f-68e5-4c87-810d-40a0140fad78" jid="pubsub.test-domain.com"/>
        <item node="node-011__9e7431ec-9b5f-41d8-ac08-3ed79836b68c" name="Node 011__9e7431ec-9b5f-41d8-ac08-3ed79836b68c" jid="pubsub.test-domain.com"/>
        <item node="node-012__5f039f31-5e78-4e78-9dd5-449bc97f2470" name="Node 012__5f039f31-5e78-4e78-9dd5-449bc97f2470" jid="pubsub.test-domain.com"/>
        <item node="node-013__d5483b6f-eb7b-4a64-9708-f175d22ec4d9" name="Node 013__d5483b6f-eb7b-4a64-9708-f175d22ec4d9" jid="pubsub.test-domain.com"/>
        <item node="node-014__d4fc3126-a7d0-4427-afdf-b1854d116efd" name="Node 014__d4fc3126-a7d0-4427-afdf-b1854d116efd" jid="pubsub.test-domain.com"/>
        <item node="node-015__0af9188c-ffaa-444f-83fc-1f123250d12b" name="Node 015__0af9188c-ffaa-444f-83fc-1f123250d12b" jid="pubsub.test-domain.com"/>
        <item node="node-016__773045a3-8c49-431a-923b-545f81de4b44" name="Node 016__773045a3-8c49-431a-923b-545f81de4b44" jid="pubsub.test-domain.com"/>
        <item node="node-017__4a4070e9-0efc-44b6-877e-ef08f7fdc8e0" name="Node 017__4a4070e9-0efc-44b6-877e-ef08f7fdc8e0" jid="pubsub.test-domain.com"/>
        <item node="node-018__24cc4c54-809f-4564-a27a-8da02350b16b" name="Node 018__24cc4c54-809f-4564-a27a-8da02350b16b" jid="pubsub.test-domain.com"/>
        <item node="node-019__0062a0ee-3ff4-489a-8e01-2a6eda3f15db" name="Node 019__0062a0ee-3ff4-489a-8e01-2a6eda3f15db" jid="pubsub.test-domain.com"/>
        <item node="node-020__76ce198e-581a-4b8d-b203-9f283c832210" name="Node 020__76ce198e-581a-4b8d-b203-9f283c832210" jid="pubsub.test-domain.com"/>
        <item node="node-021__6e6e8f89-acf5-4eeb-9f8b-76e82595bce4" name="Node 021__6e6e8f89-acf5-4eeb-9f8b-76e82595bce4" jid="pubsub.test-domain.com"/>
        <item node="node-022__eb4c7b17-44a5-4722-bce7-897b883e3dfc" name="Node 022__eb4c7b17-44a5-4722-bce7-897b883e3dfc" jid="pubsub.test-domain.com"/>
        <item node="node-023__1666f8cd-caa6-4b56-aca5-aee04401dd87" name="Node 023__1666f8cd-caa6-4b56-aca5-aee04401dd87" jid="pubsub.test-domain.com"/>
        <item node="node-024__fd6b8cbd-605b-49df-a86a-4740f22a2835" name="Node 024__fd6b8cbd-605b-49df-a86a-4740f22a2835" jid="pubsub.test-domain.com"/>
        <item node="node-025__ca4a4063-5bed-46ab-9a96-ef6043309427" name="Node 025__ca4a4063-5bed-46ab-9a96-ef6043309427" jid="pubsub.test-domain.com"/>
        <item node="node-026__67766ad4-e353-4677-ba8d-ddce58a85fb9" name="Node 026__67766ad4-e353-4677-ba8d-ddce58a85fb9" jid="pubsub.test-domain.com"/>
        <item node="node-027__3fe582b5-345b-491b-a877-e02a488af826" name="Node 027__3fe582b5-345b-491b-a877-e02a488af826" jid="pubsub.test-domain.com"/>
        <item node="node-028__df00c937-cd34-4b13-a718-064a0648ad24" name="Node 028__df00c937-cd34-4b13-a718-064a0648ad24" jid="pubsub.test-domain.com"/>
        <item node="node-029__b52f8d8e-d521-4d58-9608-d380b62b88ae" name="Node 029__b52f8d8e-d521-4d58-9608-d380b62b88ae" jid="pubsub.test-domain.com"/>
        <item node="node-030__513152d2-1773-470f-87ab-d4f98afd7cb8" name="Node 030__513152d2-1773-470f-87ab-d4f98afd7cb8" jid="pubsub.test-domain.com"/>
    </query>
</iq>

One obvious solution would be publishing and querying under dedicated node - what do you think @andrzej.wojcik ?

Andrzej Wójcik (Tigase) commented 4 years ago

@wojtek I suppose that usage of a distinct node name may solve the issue as it may be caused by some concurrency issues (multiple tests running at the same time). As for DerbyDB and MongoDB issues, I've addressed them and they should be fixed now.

wojciech.kapcia@tigase.net commented 4 years ago

I suppose that usage of a distinct node name may solve the issue as it may be caused by some concurrency issues (multiple tests running at the same time).

Modified the test to use dedicated node/collection.

As for DerbyDB and MongoDB issues, I've addressed them and they should be fixed now.

It looks it's passing now, thank you.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Version
tigase-server-8.2.0
Issue Votes (0)
Watchers (0)
Reference
tigase/tigase-tts-ng#54
Please wait...
Page is in error, reload to recover