Projects tigase _server tigase-pubsub Issues #76
PEP nodes are delivery last published items without checking access model! (#76)
Closed
Andrzej Wójcik (Tigase) opened 6 years ago

PEP nodes are delivery last published items without checking access model! ie. if PEP node is whitelist only it should not return last published item for anyone outside of the whitelist (with exception to the PEP/PubSub service owner).

Andrzej Wójcik (Tigase) commented 6 years ago

Wojtek, I've found this issue during work on "XEP-0048: Bookmarks" which suggests usage of PEP as private storage for conference bookmarks. This issue is I would say quite critical as due to the issue it is possible to receive or retrieve other user bookmarks which may include full connection details for MUC rooms (include password!).

I've checked this fix and added TTS-NG tests for this issue to make sure that it is fixed and will be fixed in 8.0.0. However, I suppose that this is rather a critical bug and we should update our installations ASAP. What do you think? Will you update them or should I?

wojciech.kapcia@tigase.net commented 6 years ago

Andrzej Wójcik wrote:

What do you think? Will you update them or should I?

I'll update it.

wojciech.kapcia@tigase.net commented 6 years ago

Wojciech Kapcia wrote:

Andrzej Wójcik wrote:

What do you think? Will you update them or should I?

I'll update it.

Updated to tigase-server-8.0.0-SNAPSHOT-b10023

to-do: terminated old instance once the users switch to new ones (i-0151f479b9f5eb54f and i-0151f479b9f5eb54f)

wojciech.kapcia@tigase.net commented 6 years ago

Wojciech Kapcia wrote:

to-do: terminated old instance once the users switch to new ones (i-0151f479b9f5eb54f and i-0151f479b9f5eb54f)

terminated

wojciech.kapcia@tigase.net commented 6 years ago

It looks like this test is still failing randomly. It seems, that for some reason, quick disconnect/connect could cause it?

Andrzej Wójcik (Tigase) commented 6 years ago

Wojciech, I've fixed issues related to TTS-NG TestPEP test case. It looks like Jaxmpp event bus still has some events to process after disconnect(true) returns, as adding a minor delay fixed this issue. Or at least tests are passing now without any issues.

wojciech.kapcia@tigase.net commented 6 years ago

It solved the issue.

wojciech.kapcia@tigase.net commented 6 years ago

Tigase.org will be updated in #8696

issue 1 of 1
Type
Bug
Priority
Critical
Assignee
RedmineID
8667
Version
tigase-server-8.0.0
Spent time
6h 30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-pubsub#76
Please wait...
Page is in error, reload to recover