pubsub repository should host database schema file for postgres (#7)

Closed

Activities

tom quas opened 1 decade ago

Due Date
2016-04-30

i figured there is none for postgres after running into

java.lang.RuntimeException: tigase.pubsub.repository.RepositoryException: Nodes 
list getting error
        at tigase.pubsub.modules.DiscoverItemsModule.process(DiscoverItemsModule
.java:138)

...

Caused by: org.postgresql.util.PSQLException: ERROR: function tigpubsubgetallnodes() does not exist

can you please add it? the package becomes unusable in a postgres environment.

tom quas commented 1 decade ago

working on this, i'm convinced that all database schema scripts should be located in one(!) place. IMHO, it's less error-prone to move the pubsub schema to tigase-server.

hmm, what actually keeps you from merging both projects into one repository? the current state appears overly complex.

Artur Hefczyc commented 1 decade ago

PubSub is a separate project from the Tigase. In factwe have a few PubSub implementations working with/on the Tigase. There is no reason in putting all of them into a single repository. On the contrary, I am in favor of splitting bigger beings into a smaller parts.

The PubSub component can use Tigase UserRepository to store it's data, then it is completely transparent to the kind of database you have. Whatever work with the main Tigase server, works with PubSub. However, this is not an optimal way to store PubSub data, therefore it can have own, dedicated schema, which is independent from the Tigase DB schema or even Tigase database.

I think such a separate is a good approach. You can develop and maintain PubSub independently from the Tigase code.

tom quas commented 1 decade ago

valid points. FWIW, i stared working on the migration of the mysql schema to postgres. got to admit though that i'm not the best-suited person for the job. do you have plans to do this? would it help to send you what i have?

thx for the hint regarding the user repository; guess that needs to be my temporary solution then.

Artur Hefczyc commented 1 decade ago

We plan to add support for PostgreSQL in next Tigase version.

tom quas commented 1 decade ago

that's awesome. would that be the next major or minor version?

in the meantime, feel free to look into my changes towards a postgres db schema. it's not functional or even tested yet, but could be a timesaver.

Artur Hefczyc commented 1 decade ago

Thank you for your code. We will certainly look at it.

We did not have any specific plans on when to add PostgreSQL support for Pubsub, but certainly with your support it will be one of the first minor versions.

Artur Hefczyc commented 9 years ago

Andrzej, I think this is most likely completed a while ago. If so, please close the ticket.

Andrzej Wójcik (Tigase) commented 9 years ago

Closing this issue as PubSub already has PostgreSQL support (which was even rewritten since this issue was created).

Type	Bug
Priority	Blocker
Assignee	Artur Hefczyc
RedmineID	784

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-pubsub#7