Projects tigase _server tigase-pubsub Issues #58
Properly handle comparison of JIDs (#58)
Closed
Andrzej Wójcik (Tigase) opened 8 years ago
Due Date
2016-10-27
Andrzej Wójcik (Tigase) commented 8 years ago

I updated schema and improved code to make it properly compare JIDs. I executed tests for each DB schema and all tests for DAO implementation are passing for every database.

I also update ACS for PubSub to make it work with updated version of PubSub component.

wojciech.kapcia@tigase.net commented 8 years ago

Looks good!

I would only explicitly define Unicode character encoding in byte[] hash = md.digest(data.toLowerCase().getBytes()); in Derby SPs.

wojciech.kapcia@tigase.net commented 8 years ago

Andrzej, as this is a new schema version, after making changes please assign ticket to Daniel so he can update documentation with the correct schema version ( %daniel , this is applicable to the upcomming 7.2.x version, i.e. origin/master branch )

Andrzej Wójcik (Tigase) commented 8 years ago

%wojtek I replaced usage of getBytes() with getBytes(UTF8) in each implementation of StoredProcedures class including also implementations from MUC, Tigase Server, MA and MUC. Additionally I did same change to functions used in Tigase Mongo project for hashing JIDs.

Daniel Wisnewski commented 8 years ago

Added notation to documentation of pubsub upgrade.

issue 1 of 1
Type
Task
Priority
Normal
Assignee
RedmineID
4654
Spent time
6h
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-pubsub#58
Please wait...
Page is in error, reload to recover