-
Related
- Exception thrown within StoredProcedure that has transaction can cause a lock (tigase/_server/tigase-message-archiving#79) Closed
- Exception thrown within StoredProcedure that has transaction can cause a lock (tigase/_server/tigase-muc#154) Closed
- Exception thrown within StoredProcedure that has transaction can cause a lock (tigase/_server/server-core#1347) Closed
- Release Tigase Server 8.2.2 (tigase/_server/server-core#1348) Closed
- Deadlocks in MySQL schema (#126) Closed
-
Fixes applied. https://github.com/tigase/tigase-pubsub/pull/21
-
Merged, let's wait for the TTS-NG results and backport it if evenrything is OK (though, this one would be good candidate to test repositories with TestContainers).
Curiously enough, we had those handlers (without
RESIGNAL;
though), but they were removed in #issue #126. -
The tests passed (https://tc.tigase.net/buildConfiguration/TigaseTtsNgTests_MySQL/173170). Could you backport it to tigase-server-8.2.x (it had issue #5.0.0)
-
I've created a new branch in
tigase-pubsub
5.0.x-bugfix that contains ported changes to MySQL schema. I've added empty SQL files for other databases as I think they are required. I think this is all that is required to backport those changes, but please review them as I've not tested them (just copied the whole file from 5.2.0 and stripped unnecessary procedures from 5.2.0 as there were not other changes related to those procedures, beside adding handlers, since 5.0.0).Is there anything else to be done? I'm wondering if we will need to release 5.1.x bugfix as well.. as 5.0.1 would be superior to 5.1.0 in this area.. but simple merge from 5.0.x will not be sufficient as those changes would not be loaded - files should be renamed to 5.1.1 if I recall correctly.
-
-
We can simplify branch naming, i.e. tigase-issue #5.0.x (just like in server, i.e. https://github.com/tigase/tigase-server-distribution/branches tigase-server-8.2.x, tigase-server-8.3.x, etc )
-
it seems that
TigPubSubWriteItem()
misses the handler declaration? -
As per chat discussion, having it in the server in procedure related to updating user password may be a "good to have" as it's used extensively in this particular case.
-
Type |
Bug
|
Priority |
Normal
|
Assignee | |
Version |
tigase-server-8.4.0, tigase-server-8.2.2
|
-
tigase-server-8.4.0 Closed
Execution concurrently same stored procedure that has transaction inside leads to lock.
Adding exit handler to stored procedures that have the transactions solves the issue:
@andrzej.wojcik please check remaining components (muc, MA, UA, MIX) for stored procedures that are still used and use transactions and add same fix (and please include the comment to not remove the handler).
It would be ideal to have a test for this case (possibly unit-test, but it would be problematic)
To be backported to Tigase Server 8.2.2
Some context: https://stackoverflow.com/a/60230093/211453:
~
MySQL has a timeout for locks:
innodb_lock_wait_timeout
, which by default is 50s