Cache usage statistics are not collected/computed correctly (#135)

wojciech.kapcia@tigase.net opened 2 years ago

No description

Andrzej Wójcik (Tigase) commented 2 years ago

Not all methods in LRUCache are properly incrementing counters, resulting in requests not being increment, ie. in case of putIfAbsent method.

Andrzej Wójcik (Tigase) commented 2 years ago

The issue was fixed and JavaDoc was added to describe the differences between 2 cache classes. PR at https://github.com/tigase/tigase-pubsub/pull/20

wojciech.kapcia@tigase.net commented 2 years ago

Looks ok. Could you add unittest (or improve tigase.pubsub.utils.CacheTest, which is ignored) for it? To improve test coverage?

Should we consider #issue #92 as finished as well?

Andrzej Wójcik (Tigase) commented 2 years ago

I've improved test cases. I think we should.

wojciech.kapcia@tigase.net batch edited 7 months ago

Name	Previous Value	Current Value
Iterations	empty	tigase-server-8.4.0

Iterations

Issue Votes (0)

Watchers (2)

Reference

tigase/_server/tigase-pubsub#135