NPE in PubsubPublishModule?Eventbus (#106)

Wojciech Kapcia (Tigase) opened 5 years ago

[2020-08-11 08:03:57:704] [WARNING ] [       pool-1-thread-1 ] EventBusImplementation.lambda$doFireThreadPerHandler$1(): Exception during execution of event: tigase.pubsub.modules.PresenceCollectorModule.CapsChangeEvent
java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at tigase.eventbus.impl.ReflectEventListenerHandler.dispatch(ReflectEventListenerHandler.java:48)
	at tigase.eventbus.impl.EventBusImplementation.lambda$doFireThreadPerHandler$1(EventBusImplementation.java:306)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.reflect.InvocationTargetException
	at jdk.internal.reflect.GeneratedMethodAccessor49.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at tigase.eventbus.impl.ReflectEventListenerHandler.dispatch(ReflectEventListenerHandler.java:46)
	... 4 more
Caused by: java.lang.NullPointerException
	at tigase.pubsub.modules.PublishItemModule.publishLastItem(PublishItemModule.java:395)
	at tigase.pubsub.modules.PublishItemModule.publishLastItem(PublishItemModule.java:654)
	at tigase.pubsub.modules.PublishItemModule.onCapsChange(PublishItemModule.java:640)
	... 8 more

Activities

Wojciech Kapcia (Tigase) commented 5 years ago

From tigase.im (so tigase-server-8.1.0-SNAPSHOT-ish)

[2020-08-11 10:40:26:755] [FINEST  ] [       pool-1-thread-7 ] PresenceCollectorModule.addJid() : for service pept0bylsma@tigase.im - Contact cavemanjoe@improbableisland.com/Conversations.PNBq is collected.
[2020-08-11 10:40:26:755] [FINEST  ] [       pool-1-thread-7 ] ConnectionManager.writePacketToSocket(): null, type: connect, Socket: nullSocket[addr=ip-10-0-46-60.us-west-2.compute.internal/10.0.46.60,port=5277,localport=20657], jid: ip-10-0-46-60.us-west-2.compute.internal, Writing packet: from=null, to=null, DATA=[cluster type=&quot;set&quot; pr=&quot;HIGH&quot; xmlns=&quot;tigase:cluster&quot; to=&quot;pubsub@ip-10-0-46-60.us-west-2.compute.internal&quot; from=&quot;pubsub@ip-10-0-9-113.us-west-2.compute.internal&quot; id=&quot;cl-891486&quot;][control][visited-nodes][node-id]CData size: 47[/node-id][/visited-nodes][method-call name=&quot;pubsub-packet-forward-pubsub-cmd&quot;][par name=&quot;perm&quot;]CData size: 4[/par][/method-call][first-node]CData size: 47[/first-node][/control][data][presence xmlns=&quot;jabber:client&quot; to=&quot;pept0bylsma@tigase.im&quot; from=&quot;cavemanjoe@improbableisland.com/Conversations.PNBq&quot;][c xmlns=&quot;http://jabber.org/protocol/caps&quot; ver=&quot;KWQQsqlerqQGIyKLIQTBsn7Adho=&quot; hash=&quot;sha-1&quot; node=&quot;http://conversations.im&quot;/][idle xmlns=&quot;urn:xmpp:idle:1&quot; since=&quot;2020-08-11T02:05:19.600Z&quot;/][x xmlns=&quot;vcard-temp:x:update&quot;][photo]CData size: 40[/photo][/x][/presence][/data][/cluster], SIZE=886, XMLNS=tigase:cluster, PRIORITY=HIGH, PERMISSION=NONE, TYPE=set
[2020-08-11 10:40:26:756] [WARNING ] [       pool-1-thread-7 ] EventBusImplementation.lambda$doFireThreadPerHandler$1(): Exception during execution of event:

[2020-08-11 10:40:26:755] [FINER   ] [       pool-1-thread-4 ] Utils.isAllowedDomain()          : Checking is cavemanjoe@improbableisland.com allowed to see domains: []
[2020-08-11 10:40:26:755] [FINEST  ] [       pool-1-thread-4 ] NodeAffiliations.getSubscriberAffiliation(): Affiliation for cavemanjoe@improbableisland.com is {cavemanjoe@improbableisland.com/none}
[2020-08-11 10:40:26:755] [FINEST  ] [       pool-1-thread-4 ] PubSubDAOJDBC.getNodeId()        : Getting Node ID: serviceJid: pept0bylsma@tigase.im, nodeName: eu.siacs.conversations.axolotl.devicelist
[2020-08-11 10:40:26:756] [FINEST  ] [       pool-1-thread-4 ] CachedPubSubRepository.getNodeItems(): Getting node items, serviceJid: peptobylsma@tigase.im, nodeName: eu.siacs.conversations.axolotl.devicelist, key: NodeKey[serviceJid = peptobylsma@tigase.im, node = eu.siacs.conversations.axolotl.devicelist], node: null, nodeId: null
[2020-08-11 10:40:26:757] [WARNING ] [       pool-1-thread-4 ] EventBusImplementation.lambda$doFireThreadPerHandler$1(): Exception during execution of event:

[2020-08-11 11:06:55:253] [FINEST  ] [       pool-1-thread-5 ] PubSubDAOJDBC.getNodeId()        : Getting Node ID: serviceJid: pept0bylsma@tigase.im, nodeName: eu.siacs.conversations.axolotl.devicelist, nodeId: 6,383, get_node_id_sp: com.mysql.jdbc.JDBC42CallableStatement@3bc18fec: CALL TigPubSubGetNodeId(&apos;pept0bylsma@tigase.im&apos;, &apos;eu.siacs.conversations.axolotl.devicelist&apos;) 
[2020-08-11 11:06:55:253] [FINEST  ] [       pool-1-thread-5 ] CachedPubSubRepository.getNodeItems(): Getting node items, serviceJid: pept0bylsma@tigase.im, nodeName: eu.siacs.conversations.axolotl.devicelist, key: NodeKey[serviceJid = pept0bylsma@tigase.im, node = eu.siacs.conversations.axolotl.devicelist], node: null, nodeId: 6,383
[2020-08-11 11:06:55:254] [FINEST  ] [       pool-1-thread-5 ] Items.[init]()                   : Constructing Items, serviceJid: pept0bylsma@tigase.im, nodeName: eu.siacs.conversations.axolotl.devicelist, nodeId: 6,383, dao: tigase.pubsub.repository.PubSubDAOPool@42734b71
[2020-08-11 11:06:55:254] [FINEST  ] [       pool-1-thread-5 ] Items.getItemsIds()              : getItemsIds, serviceJid: pept0bylsma@tigase.im, nodeId: 6,383, dao: tigase.pubsub.repository.PubSubDAOPool@42734b71, order: byUpdateDate
[2020-08-11 11:06:55:254] [FINEST  ] [       pool-1-thread-5 ] PubSubDAOJDBC.getItemsIds()      : getting items IDs: serviceJid: pept0bylsma@tigase.im, nodeId: 6,383
[2020-08-11 11:06:55:255] [WARNING ] [       pool-1-thread-5 ] EventBusImplementation.lambda$doFireThreadPerHandler$1(): Exception during execution of event: tigase.pubsub.modules.PresenceCollectorModule.CapsChangeEvent

Andrzej Wójcik (Tigase) commented 5 years ago

@wojtek This stacktrace do not match current master branch, but looking at source code of the method which thrown that exception it looks like it was already fixed.

Wojciech Kapcia (Tigase) commented 5 years ago

It's not using the latest code:

componentInfo{Title=Tigase XML Tools, Version=4.1.0-SNAPSHOT-b284/d71d2b30, Class=tigase.xml.XMLUtils}
componentInfo{Title=Tigase Utils, Version=4.1.0-SNAPSHOT-b427/7bed427f, Class=tigase.util.ClassUtil}
componentInfo{Title=Tigase XMPP Server, Version=8.1.0-SNAPSHOT-b5568/427f47cb, Class=tigase.server.XMPPServer}
componentInfo{Title=Tigase XMPP Server Distribution, Version=8.1.0-SNAPSHOT-b10700/4086d2cd, Class=tigase.dist.XmppServerDist}

So build from March this year. Considering your assessment I'm closing it.

Type	Bug
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	tigase-server-8.2.0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-pubsub#106