Projects tigase _server tigase-pubsub Issues #100
Create node request do not respond with <create/> element (#100)
Andrzej Wójcik (Tigase) opened 4 years ago

Create node request do not respond with element

Andrzej Wójcik (Tigase) commented 4 years ago

I've added pubsub-create to the response as the XEP-0060 states:

If no error occurs, the pubsub service SHOULD create the node, generate a NodeID that is unique within the context of that service, and inform the user of success (including the NodeID in the response).

and then:

Note: When a service successfully creates a node on behalf of the requesting entity, it MUST return an IQ result (in accordance with XMPP Core). If the node creation request did not specify a NodeID and the service supports creation of instant nodes, the service MUST specify the created NodeID in the IQ result. Similarly, if the node creation request specified a NodeID but the service modified the NodeID before creating the node, the service MUST also specify the modified node in the IQ result. In all other cases, the service MAY specify the NodeID in the IQ result but the node creator MUST NOT depend on receiving it from the service (since the node creator can determine which node was created by tracking the 'id' attribute that it specified for the IQ-set).

so while previous response was valid according to the XEP, I do think that having pubsub-create in the response with node can be useful.

@bmalkow Do you agree? or should I rollback this change?

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Spent time
30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-pubsub#100
Please wait...
Page is in error, reload to recover