Check getOccupantsCount() implementation (#73)

Bartosz Małkowski opened 10 years ago

Would you like to check if ClusterdRoom.getOccupantsCount() is implemented correctly (to be honest Room.getOccupantsCount() is used currently)?

Make sure it returns number of occupants in room calculated globally (not only on current cluster node).

Andrzej Wójcik (Tigase) commented 10 years ago

I checked implementation of getOccupantsCount() method in RoomClustered class and as you mentioned method from Room class was used.

I added proper implementation of this method to getOccupantsCount() to return number of room occupants from all cluster nodes and verified that nowhere in code this method was expected to return number of occupants from single cluster node.
Bartosz Małkowski commented 10 years ago

Thank you.
Login to comment

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-muc#73