Projects tigase _server tigase-muc Issues #39
Ghotbuster ping-every-minute does not seem work (#39)
Closed
Rui Ferrao opened 1 decade ago

I have enabled the ping-every-minute option on the latest snapshot. I then connect a new client and create a new room. Then i just leave it idle.

I see this on the logs every minute :

Pinging 1000 known jids

But no ping is actually ever sent to the user, which is completely idle.

Rui Ferrao commented 1 decade ago

The fix in rev. 2ddae881 works nicely for this as well.

Rui Ferrao commented 1 decade ago

Patch attached.

Bartosz Małkowski commented 1 decade ago

For me everything is ok.

Yes! Ghost detection is started every minute.

No! It doesn't pings each user every minute.

Ghostbuster pings only users with inactivity time greater that one hour. And pings no more than 1000 jids at once.

Rui Ferrao commented 1 decade ago

Bartosz, i think you are forgetting about this property :

muc/ping-every-minute[B]=true

It was added a while ago and should make the MUC Ping every minute.

Bartosz Małkowski commented 1 decade ago

I changed 'ping-every-minute' to 'search-ghosts-every-minute' (old value is still usable).

It was misleading name of property.

This property set to 'true' causes executing procedure of ghosts searching (clients with inactivity time > 1h) every minute instead of every hour. Thats all.

Rui Ferrao commented 1 decade ago

Although this is not what i wanted, i have to accept it and manage the ping-every-minute patch from my side then.

Can i just ask you why do you not consider a smaller ping value than 1h? Maybe for the typical IM application it does not make a difference, but for other types of applications where you can/want to control the connection of your users to the servers better, it is very handy.

I am sure my application is not the only one needing this, as i got this patch from an another bug opened by someone else.

In the end, the more flexibility Tigase provides, the bigger audience / applications it can serve.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
936
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-muc#39
Please wait...
Page is in error, reload to recover