Incorrect error type packet handling (#21)

Artur Hefczyc opened 1 decade ago

Please have a look at this ASAP. Our logs are overfilled with messages like this. This affects all services.

2011-10-25 15:55:56 MUCComponent.processStanzaPacket() WARNING: Problem during generate error response

tigase.xmpp.PacketErrorTypeException: The packet has already 'error' type: from=null, to=null, DATA=, SIZE=366, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=REMOTE, TYPE=error

    at tigase.xmpp.Authorization.getResponseMessage(Authorization.java:949)

    at tigase.muc.exceptions.MUCException.makeElement(MUCException.java:90)

    at tigase.muc.MUCComponent.processStanzaPacket(MUCComponent.java:328)

    at tigase.muc.MUCComponent.processPacket(MUCComponent.java:303)

    at tigase.server.AbstractMessageReceiver$QueueListener.run(AbstractMessageReceiver.java:1337)

Activities

Bartosz Małkowski commented 1 decade ago

I changed log level.
Bartosz Małkowski commented 1 decade ago

No. I need to look at it again!
Artur Hefczyc commented 1 decade ago

I think the correct solution would be to ignore packets with error type, changing log level is not enough, or even makes things worse as the problem will be hidden
Bartosz Małkowski commented 1 decade ago

Thats why I reassigned this case again to myself. It should be ignored already (the code was added long time ago). I need to debug it.
Artur Hefczyc commented 1 decade ago

Please update our both installations: tigase.org and tigase.im with the new code.
Wojciech Kapcia (Tigase) commented 1 decade ago

MUC and the rest of the libraries were updated.
Login to comment

Type	Bug
Priority	Blocker
Assignee	Artur Hefczyc
RedmineID	284

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-muc#21