Projects tigase _server tigase-muc Issues #152
Add support for XEP-0425: Message Moderation (#152)
Andrzej Wójcik (Tigase) opened 2 years ago
Andrzej Wójcik (Tigase) commented 2 years ago

Feature is now implemented in Tigase MUC (code + database schema changes) and Tigase MongoDB (required changes). Test coverage was added to TTS-NG. Those changes are in issue #152 branches for each of those projects.

wojciech.kapcia@tigase.net commented 2 years ago

https://github.com/tigase/tigase-muc/pull/14 https://github.com/tigase/tigase-mongodb/pull/4

I checked the changes and they look ok and can be merged. As per one of the comments:

Maybe with MUC 3.4 / Tigase 8.4 we should bump minimum required version of mysql to 8 and use native uuid? In 8.3 we considered deprecating 5.7 (https://projects.tigase.net/issue/serverdist-10)

Andrzej Wójcik (Tigase) commented 2 years ago

I've answered you comments on GitHub. I would move to MySQL 8.0, but just not in small version, 9.0 would be OK to do that.

wojciech.kapcia@tigase.net commented 2 years ago

OK. Though I'm somewhat less strict about that. We are not breaking an API here per-se so I think it could be acceptable. At any rate, it can be merged as it is.

Andrzej Wójcik (Tigase) commented 2 years ago

Well, if we all would agree to drop any MySQL lower than 8.0 in Tigase XMPP Server 8.4.0, then I'd gladly replace old SQL code with new one using actual UUID type in MySQL.

@kobit What do you think?

wojciech.kapcia@tigase.net added to iteration "tigase-server-8.4.0" 6 months ago
Please wait...
Page is in error, reload to recover