Projects tigase _server tigase-muc Issues #151
Handle more gracefully limitation of public room creation (#151)
Closed
wojciech.kapcia@tigase.net opened 2 years ago

#issue #133 introduced option to limit who can create public rooms. However, currently as it states, MUC protocol defines room creation via presence-join, which doesn't allow (or suggest) configuring room before creation, thus creating by default public rooms. In turn this causes majority of the clients that want to create the room to fail if the limitation is for example:

muc () {
    mucConfig () {
        'hidden-room-creation-acl' = DOMAIN
        'public-room-creation-acl' = DOMAIN_ADMIN
    }
}

(i.e. create public rooms by domain admin and hidden rooms without restrictions for domain users)

It would be better to gracefully fallback to hidden-room creation on presence-join if the user has permission to create such instead of flatly refusing to create the room altogether.

wojciech.kapcia@tigase.net commented 2 years ago

Created new AbstractMuc test to make working on the issue easier. There were some issues with TigaseKernel and injecting dependencies correctly / in correct scope. Added graceful fallback as described in the main comment. Fixed Discovery module as well while on it.

issue 1 of 1
Type
New Feature
Priority
Normal
Assignee
Version
tigase-server-8.3.0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-muc#151
Please wait...
Page is in error, reload to recover