StringIndexOutOfBoundsException in IqStanzaForwarderModule (#141)

Wojciech Kapcia (Tigase) opened 4 years ago

[2021-03-08 14:11:00:929] [FINEST  ] [              in_0-muc ] IqStanzaForwarderModule.process(): Error during forwarding IQ
java.lang.StringIndexOutOfBoundsException: begin 0, end 8, length 7
	at java.base/java.lang.String.checkBoundsBeginEnd(String.java:3319)
	at java.base/java.lang.String.substring(String.java:1874)
	at tigase.muc.modules.IqStanzaForwarderModule.forwardPacket(IqStanzaForwarderModule.java:188)
	at tigase.muc.modules.IqStanzaForwarderModule.process(IqStanzaForwarderModule.java:133)
	at tigase.component.modules.StanzaProcessor.process(StanzaProcessor.java:164)
	at tigase.component.modules.StanzaProcessor.processPacket(StanzaProcessor.java:85)
	at tigase.component.AbstractKernelBasedComponent.processPacket(AbstractKernelBasedComponent.java:81)
	at tigase.muc.MUCComponent.processPacket(MUCComponent.java:122)
	at tigase.muc.cluster.MUCComponentClustered.processPacket(SourceFile:87)
	at tigase.server.AbstractMessageReceiver$QueueListener.run(AbstractMessageReceiver.java:1397)

Related
- Add support for <iq/> forwarding with multiple resources joined (#137) Closed

Activities

Wojciech Kapcia (Tigase) commented 4 years ago

(log visible to Tigase Team)

[2021-03-08 14:11:00:924] [FINEST  ] [              in_0-muc ] SocketThread.addAllWaiting()     : ADDED OP_READ: SocketIO, ID: null, connected Socket[addr=ip-10-0-26-157.us-west-2.compute.internal/10.0.26.157,port=5277,localport=46880]
[2021-03-08 14:11:00:924] [FINEST  ] [              in_0-muc ] AbstractStrategy$PacketForwardCmd.executeCommand(): received packet from=null, to=null, DATA=<iq id="spng-17" type="result" xmlns="jabber:client" to="2ftxropntzpzn@muc.sure.im/kasafik" from="kasafik@sure.im/converse.js-123534053"/>, SIZE=138, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=result, STABLE_ID=null forwarded from node muc@ip-10-0-26-157.us-west-2.compute.internal
[2021-03-08 14:11:00:924] [FINEST  ] [              in_0-muc ] AbstractStrategy$PacketForwardCmd.executeCommand(): forwarded packet added to processing queue of component = from=null, to=null, DATA=<iq id="spng-17" type="result" xmlns="jabber:client" to="2ftxropntzpzn@muc.sure.im/kasafik" from="kasafik@sure.im/converse.js-123534053"/>, SIZE=138, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=result, STABLE_ID=null
[2021-03-08 14:11:00:924] [FINEST  ] [              in_0-muc ] ShardingStrategy.getNodeForRoom(): room = 2ftxropntzpzn@muc.sure.im, selected node = muc@ip-10-0-5-27.us-west-2.compute.internal to handle this room
[2021-03-08 14:11:00:925] [FINER   ] [              in_0-muc ] Ghostbuster2.update()            : Update activity of kasafik@sure.im/converse.js-123534053
[2021-03-08 14:11:00:925] [FINER   ] [              in_0-muc ] StanzaProcessor.processPacket()  : Received: <iq id="spng-17" type="result" xmlns="jabber:client" to="2ftxropntzpzn@muc.sure.im/kasafik" from="kasafik@sure.im/converse.js-123534053"/>
[2021-03-08 14:11:00:925] [FINEST  ] [              in_0-muc ] StanzaProcessor.process()        : Processing packet: from=null, to=null, DATA=<iq id="spng-17" type="result" xmlns="jabber:client" to="2ftxropntzpzn@muc.sure.im/kasafik" from="kasafik@sure.im/converse.js-123534053"/>, SIZE=138, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=result, STABLE_ID=null
[2021-03-08 14:11:00:925] [FINER   ] [              in_0-muc ] StanzaProcessor.process()        : Handled by module class tigase.muc.modules.IqStanzaForwarderModule
[2021-03-08 14:11:00:926] [FINEST  ] [              in_0-muc ] IqStanzaForwarderModule.process(): Processing IQ stanza, from: kasafik@sure.im/converse.js-123534053, to: 2ftxropntzpzn@muc.sure.im, recipientNickname: kasafik, senderNickname: kasafik, senderRole: moderator 
[2021-03-08 14:11:00:929] [FINEST  ] [              in_0-muc ] IqStanzaForwarderModule.process(): Error during forwarding IQ

Bartosz Małkowski commented 4 years ago

Better let @andrzej.wojcik look at it. This is his code, and I'm not sure why it is wrote as is.
Andrzej Wójcik (Tigase) commented 4 years ago

Could you review if my changes are correct?
Bartosz Małkowski commented 4 years ago

I think it is good workaround for self pinger.
Login to comment

Type	Bug
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)
Version	tigase-server-8.2.0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-muc#141