Projects tigase _server tigase-muc Issues #136
MUC specification supported by Tigase MUC is out of data (#136)
Andrzej Wójcik (Tigase) opened 4 years ago

MUC specification (especially MUC room config) has changed and in some cases it is not compatible with what we support (we are missing things), ie. we do not support muc#roomconfig_whois option which some time ago was muc#roomconfig_anonymity setting. Also fully anonymous mode is gone from the specification.

It would be nice to review MUC room config support and bring it up to date.

Bartosz Małkowski commented 4 years ago

I changed this config option. I also updated few status codes. I should not have any outdated things in MUC.

Andrzej Wójcik (Tigase) commented 4 years ago

@bmalkow I've reviewed your changes and make a comment on GitHub on your change to point possible issues (final fields annotated with @ConfigField).

Another thing that bothers me, will this change correctly convert from the old configuration? I was not able to find any conversion code on loading, but maybe it was not so obvious.

As for other changes, they look OK, but we will know for sure after TTS-NG tests will pass.

Bartosz Małkowski commented 4 years ago

I need to improve RoomConfig:

  • do not keep whole Form all the time
  • add conversion deprecated fields
Andrzej Wójcik (Tigase) commented 4 years ago

@bmalkow Thanks, now it looks OK. Let's wait for TTS-NG results and if they will pass we can close this task.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Version
tigase-server-8.2.0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-muc#136
Please wait...
Page is in error, reload to recover