Code 303 is sending too often (#135)

Closed

Activities

Bartosz Małkowski opened 4 years ago

Affected versions	Due Date
tigase-issue #3.1.0	2020-10-07

Status code 303 is sent every time by component. It must be sent ONLY on nickname change.

The issue was reported in our support room:

[2020-10-04 10:50:19] <pep.>: "MattJ is now known as MattJ" what kind of magic is this? I'm curious why the server would be sending something like this (here in this room) [2020-10-04 18:05:02] : pep.: hmm didn't see that on Conversations [2020-10-05 10:48:27] <pep.>: moparisthebest, well conversations doesn't display nick changes [2020-10-05 10:48:45] <>: And the nick actually hasn't changed [2020-10-05 13:28:44] : Whitespace? [2020-10-05 13:30:00] <>: I don't think whitespace explains it ?? [2020-10-05 13:59:08] : Ugh

wojciech.kapcia@tigase.net commented 4 years ago

I quickly check the code and I'm not sure it's correct: have you completely removed notifying about nick change? I don't see anywhere tigase.muc.modules.PresenceModule.PresenceWrapper#STATUS_CODE_NEW_NICKNAME being used nor any invocation about nickname. On the other hand - it seems we don't support nick changing as per: tigase.muc.modules.PresenceModuleImpl#processChangeNickname. If so then it's ok I guess - can you confirm @bmalkow ?

Bartosz Małkowski commented 4 years ago

It is correct: we do not need support changing nickname since years.

Andrzej Wójcik (Tigase) commented 4 years ago

This change broke MUC-ACS which was depending on deleted method and now this buggy version is deployed on tigase.org installation. Tigase ACS MUC was not depending on newest version for building (as we bump dependencies when required) and due to that this bug was not detected by TTS-NG.

Bartosz Małkowski commented 4 years ago

Fixed.

Andrzej Wójcik (Tigase) commented 4 years ago

I've deployed fixes on tigase.org and it looks like it is working now.

Type	Bug
Priority	Major
Assignee	Andrzej Wójcik (Tigase)
Version	Candidate for next minor release
Estimation	4h

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-muc#135