Projects tigase _server tigase-muc Issues #109
Room discovery returns 'internal-server-error' (#109)
Closed
Andrzej Wójcik (Tigase) opened 6 years ago

On our installations server discovery returns internal-server-error instead of returning a list of rooms available.

Andrzej Wójcik (Tigase) commented 6 years ago

I've found out that it was possible to create a room without a localpart in a JID by sending:

<iq type="set" to="muc.domain" id="1">
<query xmlns="http://jabber.org/protocol/muc#owner">
<x xmlns="jabber:x:data"/>
</query>
</iq>

where muc.domain is address of a MUC component.

Entries like that (without localpart in a JID) are invalid and caused NPE in the service discovery module.

I've fixed this issue by:

  • omitting rooms without localpart in JID from discovery
  • adding protection to make sure that it is not possible to create rooms like that anymore
  • added code which removes rooms without localpart in JID on the service startup

Bartosz, please review my changes.

Bartosz Małkowski commented 6 years ago

Looks good.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
8200
Version
tigase-server-8.0.0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-muc#109
Please wait...
Page is in error, reload to recover