NPE in AbstractMAMProcessor.updatePrefrerences() (#66)

Activities

wojciech.kapcia@tigase.net opened 4 years ago

java.lang.NullPointerException
	at tigase.archive.processors.AbstractMAMProcessor.updatePrefrerences(AbstractMAMProcessor.java:120)
	at tigase.archive.processors.AbstractMAMProcessor.process(AbstractMAMProcessor.java:98)
	at tigase.server.xmppsession.SessionManager$ProcessorWorkerThread.process(SessionManager.java:2646)
	at tigase.util.processing.WorkerThread.run(WorkerThread.java:67)

wojciech.kapcia@tigase.net commented 4 years ago

Relevant stanza.

[2020-08-27 08:35:09:121] [SEVERE  ] [ urn:xmpp:mam:1-proc-0 ] WorkerThread.run()               : tigase.server.xmppsession.SessionManager$ProcessorWorkerThread,(urn:xmpp:mam:1-proc-0) Exception during packet processing: from=c2s@ip-10-0-9-172.us-west-2.compute.internal/10.0.9.172_5222_139.162.240.38_34237, to=sess-man@ip-10-0-9-172.us-west-2.compute.internal, DATA=[iq from="cifonclick@jabber.today/xabber-web-e54291e9" xmlns="jabber:client" type="set" id="e16aa7e2-752d-475b-8ae0-f5f73f06e546:sendIQ"][prefs xmlns="urn:xmpp:mam:1" default="always"][always/][never/][/prefs][/iq], SIZE=214, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=AUTH, TYPE=set, STABLE_ID=cb23c888-db2f-4b45-a302-e61dc7ea68b2
java.lang.NullPointerException
	at tigase.archive.processors.AbstractMAMProcessor.updatePrefrerences(AbstractMAMProcessor.java:120)
	at tigase.archive.processors.AbstractMAMProcessor.process(AbstractMAMProcessor.java:98)
	at tigase.server.xmppsession.SessionManager$ProcessorWorkerThread.process(SessionManager.java:2646)
	at tigase.util.processing.WorkerThread.run(WorkerThread.java:67)

Andrzej Wójcik (Tigase) commented 4 years ago

The issue was caused by not checking if getChildren() message is returning NULL or a list.

Type	Bug
Priority	Normal
Assignee	wojciech.kapcia@tigase.net
Version	tigase-server-8.2.0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-message-archiving#66