Projects tigase _server tigase-http-api Issues #86
Add s3 backend for http-upload (#86)
Closed
wojciech.kapcia@tigase.net opened 5 years ago
No description
wojciech.kapcia@tigase.net commented 4 years ago

(slating for 8.2.0 as it will be potentially useful for Kangaroo)

Andrzej Wójcik (Tigase) commented 4 years ago

New storage option was implemented (but not tested in real life) and documentation was added to the project.

wojciech.kapcia@tigase.net commented 4 years ago

Build/documentation fixed.

wojciech.kapcia@tigase.net commented 4 years ago

@andrzej.wojcik after quickly taking a look - I think it would be prudent to include default-virtual-host in the key. In theory we could use it for bucket name, but with many installations this would quickly pollute the list of buckets. Having something under one bucket and differentiate installations by main-vhost-keys seems quite useful - what do you think?

Andrzej Wójcik (Tigase) commented 4 years ago

@wojtek Being able to set a prefix for a data stored within a bucket could be useful. However, I do not agree that we should use main-vhost-keys as this most likely will be problematic (someone wants to change vhost?, etc.)

I suppose it would be better to allow to set (in the config file) bucket-prefix which, if present, would be added as a prefix to the file key in the bucket. (this prefix could be set in the EC2 instance enviroment and retrieved by TDLS.

wojciech.kapcia@tigase.net commented 4 years ago

+1

Prefix wise, it could be configure to use same environment variable as main-vhost-key.

Andrzej Wójcik (Tigase) commented 4 years ago

I've added bucketKeyPrefix property which when not null and not blank will be used as a prefix for S3 key generation for uploaded/downloaded files. I've updated documentation as well.

wojciech.kapcia@tigase.net commented 4 years ago

Moved documentation to http-api project with appropriate NOTE about requirement of extras binaries and dependencies. Included all required dependencies in -dist-max distribution packages.

I was pondering updating to aws sdk2 to limit number of dependencies (it currently allows using internal JVM http client instead of using Apache's: https://aws.amazon.com/blogs/developer/aws-sdk-for-java-2-x-released/, https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/setup-project-maven.html#sdk-as-dependency) but the potential saving would be minimal.

issue 1 of 1
Type
Task
Priority
Normal
Assignee
Version
tigase-server-8.2.0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/tigase-http-api#86
Please wait...
Page is in error, reload to recover