Step 3 Load Configuration (#30)

Closed

Activities

Eric Dziewa opened 8 years ago

Due Date
2016-09-04

Looking on http://cluster-c.xmpp-test.net:8080/setup/?step=3 U:admin@cluster-c.xmpp-test.net P: pass

This installation uses the latest nightly. Load configuration is not right. Initially displays this:

config-type=null
--virt-hosts=null
--admins=null


--user-db-uri=jdbc:null://null/null?user=null&password=null


--sm-plugins=

Pressing reload from file shows this:

config-type=--gen-config-def
--virt-hosts=cluster-c.xmpp-test.net
--admins=admin@cluster-c.xmpp-test.net


--user-db-uri=jdbc:mysql://c05.xmpp-test.net/tigase?user=tigase&password=esagit


--sm-plugins=

--comp-name-1=http
--comp-class-1=tigase.http.HttpMessageReceiver

The actual init.properties is this:

config-type=--gen-config-def
--admins = admin@cluster-c.xmpp-test.net
--virt-hosts =   cluster-c.xmpp-test.net

#--debug=server,xmpp.impl,management

--cluster-mode = true
--cluster-nodes=c01.xmpp-test.net,c02.xmpp-test.net,c03.xmpp-test.net,c04.xmpp-test.net

#--sm-plugins=+message,-msgoffline,-amp

#--auth-db=mysql
#--auth-db-uri=jdbc:mysql://localhost/tigase?user=tigase&password=esagit
#--auth-db=tigase-auth
--user-db=mysql
#--user-db-uri=jdbc:mysql://localhost/tigase?user=tigase&password=esagit&autoCreateUser=true
--user-db-uri=jdbc:mysql://c05.xmpp-test.net/tigase?user=tigase&password=esagit&autoCreateUser=true

--data-repo-pool-size=30

#--user-db=sqlserver
#--user-db-uri=jdbc:jtds:sqlserver://192.99.33.152:1433;databaseName=tigasedb_cluster_c;user=tigase_cluster_c;password=tigase_cluster_c_pass;schema=dbo;lastUpdateCount=false;autoCreateUser=true

#--user-db-uri=jdbc:jtds:sqlserver://192.99.33.152:1433;databaseName=tigasedb_cluster_c;user=tigase_cluster_c;password=tigase_cluster_c_pass;schema=dbo;lastUpdateCount=false;autoCreateUser=true;maxStatements=0
#--user-db-uri=jdbc:sqlserver://192.99.33.152:1433;databaseName=tigasedb_cluster_c;user=tigase_cluster_c;password=tigase_cluster_c_pass;schema=dbo;lastUpdateCount=false;autoCreateUser=true


--monitoring=jmx:9050
#--stats-history=2160,10
--stats-history=300,10

--sm-cluster-strategy-class=tigase.server.cluster.strategy.OnlineUsersCachingStrategy

--comp-name-1=http
--comp-class-1=tigase.http.HttpMessageReceiver

--customer-id=44me46irjvdi7dddiej0tuh1hq

Andrzej Wójcik (Tigase) commented 8 years ago

This is correct (almost).

By default configuration is empty - you need to press load configuration to load it from file.

After reloading not all lines are in generated config - this is due to fact that setup is not aware of every single configuration property. Also in some cases it is not able to parse line values.

We can improve it but:

In my opinion if someone changed config file manually it may not expect it to be properly parsed.
Not all properties are supported as it is very big task to actually support every property in this web setup.

I think it is good as it is for initial configuration and reconfiguration for first time users of Tigase XMPP Server.

If we want to fix it, then I suggest to allow to run it only for initial setup and remove any possiblity to load configuration as I mentioned it will be very hard to add support for every property.

%kobit What do you think?

Andrzej Wójcik (Tigase) commented 8 years ago

%kobit Could you answer my question from previous comment?

Artur Hefczyc commented 8 years ago

I think that after initial setup, the configurator should allow to load config file for manual modifications only. I mean, it should load them into a web form into a text area field. An admin can edit the config file and save it to HDD. It would be also good to make an automatic backup of the original file to make it easy to revert all changes.

Andrzej Wójcik (Tigase) commented 8 years ago

%kobit I modified setup to work in way you described it.

%eric Please verify that it works correctly now. If init.properties file is configured by Tigase and restarted then entering setup pages will lead to new page with displayed configuration which can be modified and saved.

If it will work correctly then I think %daniel should check that documentation matches changed behaviour of setup.

Eric Dziewa commented 8 years ago

Works great.

Daniel Wisnewski commented 8 years ago

Documentation updated and annotated.

Type	Bug
Priority	Normal
Assignee	Eric Dziewa
RedmineID	4385

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/tigase-http-api#30