[FCM] add FCM provider private key validation when uploading it via rest (#157)

Wojciech Kapcia (Tigase) opened 1 year ago

Currently uploading FCM service file via web-admin doesn't correctly inform about the error and only reloads page even though correct error is returned:

<iq to="admin@(…)/atlantiscity" id="7e054aeb-01e0-426a-a931-d0a382efd7da" type="error" from="push.(…)">
<command xmlns="http://jabber.org/protocol/commands" sessionid="3fab5a16-0c72-4720-977b-fa8d268e44a1" node="set-fcm-service-account">
<x xmlns="jabber:x:data" type="submit">
<field type="list-single" var="provider">
<value>fcm-http-v1</value>
</field>
<field type="text-multi" var="service-account">
<value>{</value>
<value>    "project_info": {</value>
…
<value>    "configuration_version": "1"</value>
<value>} </value>
</field>
</x>
</command>
<error code="400" type="modify">
<bad-request xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas" xml:lang="en">Service account is not a valid JSON service account file content!</text>
</error>
</iq>

Only blank page is shown in web-admin

Captura de pantalla 2024-09-19 a las 12.49.00.png

Activities

Wojciech Kapcia (Tigase) added to iteration "tigase-server-8.5.0" 1 year ago

Wojciech Kapcia (Tigase) changed title 1 year ago

Previous Value	Current Value
[fcm] add FCM provider private key validation when uploading it via rest	[FCM] add FCM provider private key validation when uploading it via rest

Wojciech Kapcia (Tigase) moved 1 year ago
Previous Value Current Value
tigase/_server/tigase-push

tigase/tigase-http-api
Wojciech Kapcia (Tigase) moved 1 year ago
Previous Value Current Value
tigase/tigase-http-api

tigase/_server/tigase-http-api
Andrzej Wójcik (Tigase) commented 2 weeks ago

I've resolved this issue by implementing support for reporting error returned by ad-hoc command (IQ packet type errors) in admin console.
Andrzej Wójcik (Tigase) changed state to 'In QA' 2 weeks ago
Previous Value Current Value
Open

In QA
Andrzej Wójcik (Tigase) added to iteration "tigase-server-8.5.0" 2 weeks ago
Andrzej Wójcik (Tigase) changed fields 2 weeks ago
Name Previous Value Current Value
Assignee

andrzej.wojcik

wojtek
Wojciech Kapcia (Tigase) changed state to 'Closed' 7 days ago
Previous Value Current Value
In QA

Closed
Login to comment

Previous Value	Current Value
tigase/_server/tigase-push	tigase/tigase-http-api

Previous Value	Current Value
tigase/tigase-http-api	tigase/_server/tigase-http-api

Previous Value	Current Value
Open	In QA

Name	Previous Value	Current Value
Assignee	andrzej.wojcik	wojtek

Previous Value	Current Value
In QA	Closed

Type	Bug
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)
Version	none
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.5.0 Open

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/tigase-http-api#157