[Dashboard] Improve error handling (#155)

Wojciech Kapcia (Tigase) opened 9 months ago

We should return better http errors instead of generig "500"
it would be better to have dedicated error pages instead of default jetty ones
possible good idea would be to include root-case in there (e.g. in the linked issue the root case was TigaseStringprepException: Illegal characters in string, localpart = vishal@chat4.im but only java.lang.reflect.InvocationTargetException was displayed -- possibly use tigase.util.ExceptionUtilities#getExceptionRootCause)

Wojciech Kapcia (Tigase) added "Related" tygrys/tygrys#245 9 months ago
Andrzej Wójcik (Tigase) changed state to 'In Progress' 3 weeks ago
Previous Value Current Value
Open

In Progress
Andrzej Wójcik (Tigase) changed state to 'In QA' 3 weeks ago
Previous Value Current Value
In Progress

In QA
Andrzej Wójcik (Tigase) commented 3 weeks ago

I've implemented custom error pages for dashboard and I've caught all error (not only exceptions) and displayed them in a proper way (custom HTML web page if HTML is accepted response according to the request).

It now reports, error code, error reason, error message (if exception) and stacktrace (full) available (unpacked from wrapping exceptions if it was wrapped.

Please review results, but I think it works better now.

Additionally, if provided field parameter will not pass validation (regex or will throw ValidationException) error message will be properly displayed and could indicate field that had incorrect value.
Andrzej Wójcik (Tigase) referenced from other issue 3 weeks ago

[Dashboard] Add form validation for fields (username) (#156)

Closed
Login to comment

Previous Value	Current Value
Open	In Progress

Previous Value	Current Value
In Progress	In QA

Iterations

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/tigase-http-api#155