SchemaLoader doesn't correclty handle all parameters (#974)

Won't Fix

Activities

wojciech.kapcia@tigase.net opened 6 years ago

This is somewhat related to #5675.

Following parameters are ignored when using install-schema/upgrade-schema commands in shell:

serverTimezone=
-L (log level)

Command:

$ ./scripts/tigase.sh install-schema etc/tigase.conf -T mysql --L ALL -H localhost --serverTimeZone=UTC -J admin@atlantiscity -N admin -U tigdb800_ext_main -P tigdb800_ext_main -D tigdb800_ext_main

2018-09-17 14:01:02.190 [main] DBSchemaLoader.init() CONFIG: Parameters: [adminPassword: admin, admins: [admin@atlantiscity], dbHostname: localhost, dbName: tigdb800_ext_main, dbPass: tigdb800_ext_main, dbRootPass: root, dbRootUser: root, dbType: mysql, dbUser: tigdb800_ext_main, file: null, ingoreMissingFiles: false, logLevel: CONFIG, query: null, serverTimezone: null, useLegacyDatetimeCode: false, useSSL: false, forceReloadSchema: false, schemaDirectory: database/]

In addition, serverTimezone should be included and described in documentation

Andrzej Wójcik (Tigase) commented 6 years ago

Actually the only issue here is misuse of the parameters.

There is no --L parameter name, but there is -L parameter letter. You should use single - instead of -- and it would just work. I could agree that it may be sometimes confusing and it could be nice to allow using --L and -logLevel but for now we accept only -L and --logLevel.

As for --serverTimeZone, it cannot work as the correct parameter name is --serverTimezone, which works just ok. Also serverTimezone is the exact parameter name used in MySQL JDBC URI, so it would be best to keep them exactly the same.

Type	Bug
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
RedmineID	8193
Version	tigase-server-8.0.0
Spent time	3h

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#974