Projects tigase _server server-core Issues #963
Remove RepoItems configuration from file. (#963)
Wojciech Kapcia (Tigase) opened 7 years ago
  • remove possibility to configure RepoItems in components
  • only allow single VHost default-virtual-host without ability to set any of it's options
  • make sure that options are correctly handled (e.g. for ext: #7903#note-4)
  • Andrzej Wójcik (Tigase) commented 7 years ago

    Done. I've updated the documentation in all places which I could find, so this should be done. But as we talked, we may need to update TTS-NG configuration and tests to comply with the changes we have made.

  • Wojciech Kapcia (Tigase) commented 7 years ago

    Re-assigning for TTS-NG configuration changes.

  • Andrzej Wójcik (Tigase) commented 7 years ago

    I've adjusted TTS-NG code and configuration. Waiting for TTS-NG execution results to confirm that changes work properly.

  • Andrzej Wójcik (Tigase) commented 7 years ago

    Please review if tests are now executed correctly.

  • Wojciech Kapcia (Tigase) commented 7 years ago

    Andrzej Wójcik wrote:

    Please review if tests are now executed correctly.

    One test fails and one is skipped - please correct it.

    • Failed Tests
    tigase.tests.ext.ComponentProtocolTest
    2018-10-03 06:37:04 | [Mutex] isItemNotified: connection:established:true :: false
    java.lang.AssertionError: expected [true] but found [false]
    
    • Skipped Tests
    tigase.tests.ext.ComponentProtocolTest
    testRemoval2 	0.000s 	Depends on method(s): tigase.tests.ext.ComponentProtocolTest.addConnectionConnect
    
  • Andrzej Wójcik (Tigase) commented 7 years ago

    The issue was caused by the fact that we no longer support jabber:component:connect protocol and jabber:component:accept needs to be used now. I've updated test case.

  • Wojciech Kapcia (Tigase) commented 7 years ago

    Still fails.

    addConnectionConnect(tigase.tests.ext.ComponentProtocolTest)  Time elapsed: 30.173 sec  <<< FAILURE!
    java.lang.AssertionError: expected [true] but found [false]
    	at org.testng.Assert.fail(Assert.java:93)
    	at org.testng.Assert.failNotEquals(Assert.java:512)
    	at org.testng.Assert.assertTrue(Assert.java:41)
    	at org.testng.Assert.assertTrue(Assert.java:51)
    	at tigase.tests.ext.ComponentProtocolTest.addConnectionConnect(ComponentProtocolTest.java:263)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:498)
    	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:108)
    	at org.testng.internal.Invoker.invokeMethod(Invoker.java:661)
    	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:869)
    	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1193)
    	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:126)
    	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109)
    	at org.testng.TestRunner.privateRun(TestRunner.java:744)
    	at org.testng.TestRunner.run(TestRunner.java:602)
    	at org.testng.SuiteRunner.runTest(SuiteRunner.java:380)
    	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:375)
    	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
    	at org.testng.SuiteRunner.run(SuiteRunner.java:289)
    	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
    	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
    	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1301)
    	at org.testng.TestNG.runSuitesLocally(TestNG.java:1226)
    	at org.testng.TestNG.runSuites(TestNG.java:1144)
    	at org.testng.TestNG.run(TestNG.java:1115)
    	at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:295)
    	at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:84)
    	at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:90)
    	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
    	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
    	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
    
  • Andrzej Wójcik (Tigase) commented 7 years ago

    I've fixed an issue - it looks like build.tigase.net machine is no longer available under this name - this name points to ELB.

issue 1 of 1
Type
New Feature
Priority
Normal
Assignee
RedmineID
7923
Version
tigase-server-8.0.0
Spent time
0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#963
Please wait...
Page is in error, reload to recover