Projects tigase _server server-core Issues #928
DefaultTypesConverter is case-sensitive with enums (#928)
Closed
wojciech.kapcia@tigase.net opened 7 years ago

Not sure if this is bug per se but currently DefaultTypesConverter is case-sensitive with enums, which obviously causes issues when configuration is not strict with it (or was converted from previous version) which may cause errors during startup.

The proposal is to make it case-insensitive (as the enums cases are currently all over the place) as alternatively adjusting documentation (eg.: http://docs.tigase.org/tigase-server/snapshot/Administration_Guide/html_chunk/watchdog.html) and converter would be… tedious without much benefit.

%kobit %andrzej.wojcik ( %bmalkow ?)

Andrzej Wójcik (Tigase) commented 6 years ago

I'm generally against allowing usage of values with different letter cases, but in this case, I agree that we should allow this - at least for compatibility reasons. However, I would still want to clean up documentation and use proper values without a need for case-insensitive lookup of enum values.

wojciech.kapcia@tigase.net commented 6 years ago

Andrzej Wójcik wrote:

I'm generally against allowing usage of values with different letter cases,

Totally agree

but in this case, I agree that we should allow this - at least for compatibility reasons. However, I would still want to clean up documentation and use proper values without a need for case-insensitive lookup of enum values.

Daniel - do you think you will be able to update documentation (case of some options)?

Daniel Wisnewski commented 6 years ago

After a thorough check of all enums in code from a grep search, I have not found any more instances of enums that are not in line with documentation and code.

wojciech.kapcia@tigase.net commented 6 years ago

Thank you.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
6842
Version
tigase-server-8.0.0
Spent time
38h 45m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#928
Please wait...
Page is in error, reload to recover