Config converter should handle configuration with spaces (#907)

Wojciech Kapcia (Tigase) opened 8 years ago

Having configuration with spaces, for example:

--queue-implementation = tigase.util.PriorityQueueStrict

is not correctly handled because converter treats key as "@--queue-implementation @" (i.e. with space at the end) while this was valid configuration option before.

Activities

Andrzej Wójcik (Tigase) commented 8 years ago

I've fixed this issue, but in fact, while loading from config file ConfiguratorAbstract was used, so it was stored in trimmed and non-trimmed version. Now, all should work properly.

Wojciech Kapcia (Tigase) commented 8 years ago

Reopening.

Admin list, vhosts, and ext repository list have the same problem:

vhost:

--virt-hosts=international.com, dev.com, qa.com, int.com…

'virtual-hosts' = [
    'int.com',
    ' international.com',
    ' dev.com',

ext:

--external=admin.com:tigase:listen:5290, sa.com:tigase:listen:5300, pa.com:tigase:listen:5270,

ext (class: tigase.server.ext.ComponentProtocol) {
…    repository {
        items = [
            'admin.com:tigase:listen:5290',
            ' sa.com:tigase:listen:5300',
            ' pa.com:tigase:listen:5270',
…

Andrzej Wójcik (Tigase) commented 8 years ago

I've fixed this issue in a more detailed way. I reviewed whole converter code looking for split(",") and replaced this part with a call to the new method which splits string, trims items and converts them to the list (as expected in most cases).
Login to comment

Type	Bug
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)
RedmineID	6364
Version	tigase-server-8.0.0
Spent time	0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#907