Better separation of utils and xmltools (#888)

Wojciech Kapcia (Tigase) opened 8 years ago

Currently tigase-utils and tigase-xmltools are inlined to tigase-server (reason was that OSGi prohibits packages across various jar) and it would be good to tackle "split packages" problem as new java9/jigsaw modules also forbid 'split packages' in modules.

%kobit yesno?

Related
- XMPP Server crash on startup (#899) Closed

Activities

Artur Hefczyc commented 8 years ago

yes
Andrzej Wójcik (Tigase) commented 8 years ago

%kobit If I'm correct this would require changing package names. As a result, it will break API, so maybe it should be done in 8.0?
Artur Hefczyc commented 8 years ago

Andrzej Wójcik wrote:

%kobit If I'm correct this would require changing package names. As a result, it will break API, so maybe it should be done in 8.0?

Definitely yes
Andrzej Wójcik (Tigase) commented 8 years ago

From my perspective, all works as expected.

Wojciech Kapcia (Tigase) commented 8 years ago

Issue with @PriorityQueueStrict@:

2017-11-04 04:14:38.015 [main]             AbstractBeanConfigurator.configure()    WARNING:  Can't prepare value of property 'priorityQueueClass' of bean 'message-router': 'tigase.util.PriorityQueueStrict'
java.lang.RuntimeException: Cannot convert to class java.lang.Class
	at tigase.kernel.DefaultTypesConverter.convert(DefaultTypesConverter.java:124)
	at tigase.kernel.beans.config.AbstractBeanConfigurator.configure(AbstractBeanConfigurator.java:301)
	at tigase.component.DSLBeanConfiguratorWithBackwardCompatibility.configure(DSLBeanConfiguratorWithBackwardCompatibility.java:49)
	at tigase.kernel.beans.config.AbstractBeanConfigurator.configure(AbstractBeanConfigurator.java:360)
	at tigase.kernel.core.Kernel.initBean(Kernel.java:123)
	at tigase.kernel.core.Kernel.getInstance(Kernel.java:286)
	at tigase.server.Bootstrap.start(Bootstrap.java:162)
	at tigase.server.XMPPServer.start(XMPPServer.java:193)
	at tigase.server.XMPPServer.main(XMPPServer.java:147)
Caused by: java.lang.ClassNotFoundException: tigase.util.PriorityQueueStrict
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at tigase.osgi.ModulesManagerImpl.forName(ModulesManagerImpl.java:105)
	at tigase.kernel.DefaultTypesConverter.convert(DefaultTypesConverter.java:122)
	at tigase.kernel.beans.config.AbstractBeanConfigurator.configure(AbstractBeanConfigurator.java:301)
	at tigase.component.DSLBeanConfiguratorWithBackwardCompatibility.configure(DSLBeanConfiguratorWithBackwardCompatibility.java:49)
	at tigase.kernel.beans.config.AbstractBeanConfigurator.configure(AbstractBeanConfigurator.java:360)
	at tigase.kernel.core.Kernel.initBean(Kernel.java:123)
	at tigase.kernel.core.Kernel.getInstance(Kernel.java:286)
	at tigase.server.Bootstrap.start(Bootstrap.java:162)
	at tigase.server.XMPPServer.start(XMPPServer.java:193)
	at tigase.server.XMPPServer.main(XMPPServer.java:147)

Wojciech Kapcia (Tigase) commented 8 years ago

While working on #5379 I noticed that all tests started to fail when the change was made. It was due to using old path to the PriorityQueueStrict class. I've adjusted the converted to handle the change.

Let's see next tests results.
Wojciech Kapcia (Tigase) commented 8 years ago
Some repositories were not adjusted, and jenkins didn't catch the change as old dependencies were used (for example 3.6.0-SNAPSHOT) which still contained old packages paths.

I have:

manually removed changed version as it seems that archiva has troubles respecting "retain only x days" and "retain only x artifacts" (or better yet - it will retain x SNAPSHOT artifacts even though they exceed the defined time; there is another option "remove released artifacts" but, given those versions haven't been released those artifacts haven't been removed).

wen't over the project and:

tigase-licence - updated dependencies and API

tigase-pubsub - removed dependency on tigase-utils and removed two test scripts as they weren't used anymore
Login to comment

Type	Task
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)
RedmineID	6206
Version	tigase-server-8.0.0
Spent time	0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#888