|
Andrzej Wójcik (Tigase) opened 7 years ago
|
|
|
I've found this during work on issue #6087. As I reviewed code this instance is not needed anywhere, so I've removed it and modified I've updated source code so that our code will use new constructors. I've left parameter with |
|
Good catch - makes sense. |
| Type |
Bug
|
| Priority |
Normal
|
| Assignee | |
| RedmineID |
6103
|
| Version |
tigase-server-8.0.0
|
| Spent time |
3h 45m
|
Issue Votes (0)
Watchers (0)
The current implementation of
RosterElementkeeps the instance ofXMPPResourceConnectioneven though it is not needed anywhere and access to this variable is private.Moreover, due to fact that roster is cached in
XMPPSessionit is possible that instance referenced inRosterElementis no longer needed as it was closed but cached entry is kept as other resource is online. Due to that, we may have in memory instances ofXMPPResourceConnectionwhich are no longer needed and should be garbage collected.