Projects tigase _server server-core Issues #846
Issues with conversion/upgrade of MUC room configuration (#846)
Closed
Andrzej Wójcik (Tigase) opened 7 years ago

As reported in #5563, it looks like there are some issues with conversion of room configuration (affiliations) and room history.

mucUpgrade.txt

Andrzej Wójcik (Tigase) commented 7 years ago

I've fixed issue with the conversion of MUC room history - there was an issue in a new schema SQL which was responsible for the conversion of MUC history. It is done on a database level to make it faster.

As for NullPointerException during run of converter on tigase.im@/@sure.im installation it was caused by malformed entries in the database. I decided not to look for a cause but added proper checks within a converters code, so it will be able to properly convert MUC rooms in this case.

As for missing affiliations/roles for @int@muc.tigase.org@. This was caused by your actions. At first, you logged to XMPP server and joined room - which created entries in new tables for @int@. Then you started converter, but converter needs to be able to handle issue during conversion, ie. exceptions. And in such cases, we need to be able to rerun converter. To achieve this goal, converter checks, if room loaded from the old repository, exists in new and if it does then room conversion is skipped.

In our case, this room existed because when you joined room before you run converter it was created, so room roles and configuration was not converted.

To sum this up. Issues within converter are fixed and conversion needs to be done before any instance of Tigase XMPP Server will be connected.

Fixes will be part of a next snapshot build.

Eric Dziewa commented 7 years ago

Didn't have any problems on tigase.org installation. There is another NPE when running on tigase.im installation. Log is attached.

Andrzej Wójcik (Tigase) commented 7 years ago

There are rooms in the database without any room configuration. I decided to remove them during conversion as they are unloadable on 7.1.x as well.

Fix will be part of a next snapshot build.

Eric Dziewa commented 7 years ago

Works good.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
5686
Version
tigase-server-8.0.0
Spent time
20h
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#846
Please wait...
Page is in error, reload to recover