DSL converter doesn't work well (#835)

Closed

Activities

wojciech.kapcia@tigase.net opened 7 years ago

Due Date
2017-06-05

plugins in sess-man are converted to "beans" array:

--sm-plugins=+zlib,amp=4,-message,-msgoffline,mobile_v2,mobile_v1,message-archive-xep-0136,message-carbons,+pep,-jabber:iq:register,spam-filter

'sess-man' {

beans = '+zlib,amp,-message,-msgoffline,mobile_v2,mobile_v1,message-archive-xep-0136,message-carbons,+pep,-jabber:iq:register,spam-filter'

}

processors in c2s are... not exactly well converted:

c2s/processors[s]=urn:xmpp:sm:3

c2s {

beans = [ 'urn:xmpp:sm:3' ]

processors {

    'urn:xmpp:sm:3' {

        'max-resumption-timeout' = 3600

        'resumption-timeout' = 90

    }

}

}

http-api component configuration is not correct afterwards

http {
    http {
        'request-timeout' = '120000'
        threads = '8'
    }
    rest {
        'api-keys' = [ 'open_access:regex=/rest/licence/.+' ]
    }
}

rest (class: tigase.http.HttpMessageReceiver) {
    http {
        'server-class' = 'tigase.http.jetty.JettyStandaloneHttpServer'
    }
}

AMP repo uri is not converted

--amp-repo-uri = 'jdbc:mysql://t2.tigase.org/…'

stays the same

Please revise complete tigase.org (t2.tigase.org) init.properties and run converter against it so that the resulting DSL config is correct and Tigase can start.

Andrzej Wójcik (Tigase) commented 7 years ago

I've made a few modifications:

added support for @-amp-repo-uri@, etc.
changed conversion of --sm-plugins and c2s/processors to separate beans instead of using beans property.

Usage of beans property was correct and expected as beans is the name of a special property which can enable/disable beans within this scope (same as --sm-plugins did).

improved conversion of for http component

Config on t2 is a total mess when it comes to the configuration of http component. My changes were focused on improving conversion, however, it will not help if a config is a mess.

improved conversion of basic-conf/logging settiings

I reviewed generated configuration and it looks correct.

wojciech.kapcia@tigase.net commented 7 years ago

Andrzej Wójcik wrote:

Config on t2 is a total mess when it comes to the configuration of http component. My changes were focused on improving conversion, however, it will not help if a config is a mess.

%andrzej.wojcik can you expound on the above?

Andrzej Wójcik (Tigase) commented 7 years ago

Sometimes http component is referenced as rest and sometimes as http but it is defined as @http. In a result not all properties will be set as config is not valid.

wojciech.kapcia@tigase.net commented 7 years ago

Andrzej Wójcik wrote:

Sometimes http component is referenced as rest and sometimes as http but it is defined as @http. In a result not all properties will be set as config is not valid.

I think this is the result of how component evolved and how it affected it´s configuration (vide https://projects.tigase.org/projects/tigase-http-api/wiki/Configuration) and having leftovers there.

At any rate, converted now works more reliable.

Referenced from commit 11 months ago