Setup runs into issues with two types of message archive (#809)

Closed

Activities

Daniel Wisnewski opened 7 years ago

Due Date
2017-05-02

Setup module shows two different checkboxes for Message Archive XEP-0146 but does not show one for MAM XEP-0313.

If the first option is selected, MA is not mentioned in init.properties (I guess since this is enabled by default).

Selecting the second option, and not the first, errors arise with MA not being active (perhaps a null option?)

}
'message-archive' (active: false) {}
'sess-man' () {
    'message-archive-xep-0136' (active: false) {}
    'urn:xmpp:mam:1' (active: false) {}
}

Interestingly selecting both results in MA being turned on, but no configuration set in Sess-man.

'sess-man' () {}
'unified-archive' () {}

I am wondering if it would be a good idea to ask the user for either/or for 146 and 313 as it seems possible to turn both on and may be confusing to people who do not realize our MA can serve both at the same time.

Daniel Wisnewski commented 7 years ago

Daniel Wisnewski wrote:

...but does not show one for MAM XEP-0313.

I see that plugins has MA-0313 on page 2, I forgot to change this before I posted ticket.

wojciech.kapcia@tigase.net commented 7 years ago

Thanks Dan for reporting this.

Andrzej, as we discussed in chat:

Options in the setup must be corrected;
ideally UA should be a sub-option to MA (and selecting UA checks MA and makes it inactive) [I know that it's possible to have fancy setup with UA and MA using separate DB but we are covering here only setup and this has to be comprehensible to user running setup].

Actual logic of resulting configuration is correct.

Andrzej Wójcik (Tigase) commented 7 years ago

I've added logic to warn a user when both components are enabled and changed processors selection logic to properly behave when UA is selected instead of MA.

Type	Bug
Priority	Normal
Assignee	wojciech.kapcia@tigase.net
RedmineID	5415
Version	tigase-server-8.0.0
Spent time	10h

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#809