Avoid cyclic processing in Kernel (#797)

Wojciech Kapcia (Tigase) opened 8 years ago

This is a followup to #4896#note-8 - we should detect cyclic dependencies and skip it:

[13:31:32] <Wójcik Andrzej #> logi puchną bo Kernel ma relacje w pętli dla DataSource

[13:32:53] <Wójcik Andrzej #> tzn. powinno wylecieć a nie próbować ponownie wczytać

[13:33:13] <Wójcik Andrzej #> i z tym się zgadzam, jak coś to wrzuć na to osobny task

Wojciech Kapcia (Tigase) commented 8 years ago

Andrzej, please adjust due-date accordingly.
Andrzej Wójcik (Tigase) commented 8 years ago

Generally speaking, circular dependencies are OK, but in case of failure both beans should be removed and not result in a loop.
Andrzej Wójcik (Tigase) commented 8 years ago

Changed description to provide correct reference to an issue #4896 - not #4880
Andrzej Wójcik (Tigase) commented 8 years ago

I've tried to replicate same situation you had and for which you attached logs, however I was not able to replicated it - beans were properly unloaded. In logs there was nothing useful which could point me to source of this issue.

Please try to replicate this using newest version and if this issue happens please create package of whole Tigase XMPP Server folder. At this point I'm not sure what caused this issue - I suspected cyclic dependencies but on my machine with same config and newest version of Tigase XMPP Server it works fine (version builded locally).
Wojciech Kapcia (Tigase) commented 8 years ago

%andrzej.wojcik Couldn't reproduce it with the latest version.
Login to comment

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#797