Projects tigase _server server-core Issues #786
XMPPResourceConnection code review (#786)
Artur Hefczyc opened 8 years ago
Due Date
2017-03-30

Method authorizeJID(...) has a call to @loginHandler.handleDomainChange(…)@. In what use-cases can it happen that domain changes? Does the protocol allows for such case? If it does, maybe it is worth adding a short in-line comment to the code with some explanation.

By the way, domains can be compared using == operator which is less resources consuming.

Bartosz Małkowski commented 8 years ago

Use case: #2522

Also, SASL allows to use "Authorization Identity" what means that privileged user (admin) may "specify an identity to act as". authzid must be BareJID so in theory changing domain is allowed.

issue 1 of 1
Type
Task
Priority
Normal
Assignee
RedmineID
5089
Version
tigase-server-8.0.0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#786
Please wait...
Page is in error, reload to recover