| Type |
Task
|
| Priority |
Normal
|
| Assignee | |
| RedmineID |
5088
|
| Version |
tigase-server-8.0.0
|
| Spent time |
0
|
Issue Votes (0)
Watchers (0)
| Type |
Task
|
| Priority |
Normal
|
| Assignee | |
| RedmineID |
5088
|
| Version |
tigase-server-8.0.0
|
| Spent time |
0
|
While looking at the SaslAuth plugin I noticed some inconsistencies in the code. I am not sure if I understand it correctly, please review the code and fix if necessary:
process(...)method.There is a condition:
if(session.isAuthorized()) {…}which if true, logs the user out and closes stream and TCP/IP connection but then there is noif-elsestatement orreturnfrom the method and it continues to process SASL requests. This seems like incorrect. The stream and connection would be closed anyway but processing SASL request in such a case is a waste of resources.