Projects tigase _server server-core Issues #785
SaslAuth code review (#785)
Artur Hefczyc opened 8 years ago
Due Date
2017-03-30

While looking at the SaslAuth plugin I noticed some inconsistencies in the code. I am not sure if I understand it correctly, please review the code and fix if necessary:

process(...) method.

There is a condition: if(session.isAuthorized()) {…} which if true, logs the user out and closes stream and TCP/IP connection but then there is no if-else statement or return from the method and it continues to process SASL requests. This seems like incorrect. The stream and connection would be closed anyway but processing SASL request in such a case is a waste of resources.

Bartosz Małkowski commented 8 years ago

You're right!

I missed it.

issue 1 of 1
Type
Task
Priority
Normal
Assignee
RedmineID
5088
Version
tigase-server-8.0.0
Spent time
1h 15m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#785
Please wait...
Page is in error, reload to recover