Projects tigase _server server-core Issues #780
last_login and last_logout are not updated with SASL SCRAM*. (#780)
Closed
wojciech.kapcia@tigase.net opened 8 years ago
Due Date
2017-03-23

%kobit you mentioned in #4878#note-1 that those are/may be needed using external tools so should this be fixed?

Artur Hefczyc commented 8 years ago

Yes, this should be fixed.

I wonder why this problem exists at all. There is/was an API in Tigase and these columns are updated automatically without any special code in the plugin. So it should work for all authentication methods. Does it not use/follow our APIs the way other plugins do?

wojciech.kapcia@tigase.net commented 8 years ago

I'll let Bartek explain it.

Bartosz Małkowski commented 8 years ago

SASL tries to not to use database stored procedure at all (well, Plain mechanism uses). Especially SCRAM mechanism reads password from database and processing it.

Artur Hefczyc commented 8 years ago

I understand, in the past not all authentication methods used stored procedures either, at least not for authentication. But they all recorded user login/logout time. I guess we lost this functionality at some point. Is the user login/logout time recorded for any other methods/mechanisms? What about SASL external?

It seems to me that it is relatively simple thing to implement and maintain but very useful so we should make sure we have it back for all authentication methods and mechanisms.

Therefore it should be implemented through some common API, in such a way that it is called automatically, even if somebody implements a new mechanism in the future. Also, make sure it is configurable, and can be switched off.

Bartosz Małkowski commented 8 years ago

I'm changing current API (*Repo) to add methods to store login time in databases. It will be called by SaslAuth, so it will works the same way for all SASL mechanisms.

Artur Hefczyc commented 8 years ago

Ok. When it's done, please close the ticket.

Bartosz Małkowski commented 8 years ago

Would you like to update Tigae-MongoDB project?

Andrzej Wójcik (Tigase) commented 8 years ago

I've fixed compilation issue of Tigase MongoDB by adding implementation of a new method and forwarding call to internal instance of @AuthRepositoryImpl@.

wojciech.kapcia@tigase.net commented 8 years ago

self-notes: new schema files added (*-7-2-sp.sql):

  • code responsible for checking version should be updated;

  • db-properties should be updated (creating *-7-2.sql and properties files);

  • including upgrade script/handling.

Not sure if #1092 will be included in 7.2.0 (as we should make it ready for release for spring-ish time frame)

wojciech.kapcia@tigase.net commented 8 years ago

Works as expected.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
5076
Version
tigase-server-8.0.0
Spent time
31h 15m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#780
Please wait...
Page is in error, reload to recover