wojciech.kapcia@tigase.net opened 8 years ago
|
|
I disagree that we should fallback to any Adjustments to However main issue with usage of But this leads to a conclusion that we need implementations of Do we need this implementations? or we accept that for basic tests with XMLRepository PubSub, MUC and MA must be disabled? |
|
To be honest I do not see much value on spending a lot of time on XMLRepository development. We should run tests over Tigase server with a real DB anyway. XMLRepository support should be really minimal what is absolutely necessary. Maybe a better option would be to focus on Derby or similar support. |
|
Andrzej Wójcik wrote:
I think that basic support for ad-hoc tests is enough. Artur Hefczyc wrote:
While it's true, it's kinda required for some parts of the code to have working repository and this is very handy for a unit tests (for which setting up separate database may be a hassle and it speeds up making changes without braking things); all in all this basic XMLRepository implementation is definitely handy.
On that note - we need Derby only for... "single machine simple deployment to show that Tigase is working" (i.e. someone wants to install it and check if/how it works). And Derby is slightly "challenging" to maintain (mostly by enforcing SP within Java code as well as difficult updates). Maybe for that end we should adopt hsqldb which while similar in principles to Apache Derby offers support for SQL user-defined stored procedures and functions so it would be more in line with other database hence less overhead to make support for Derby working. |
|
Wojciech Kapcia wrote:
Indeed, I am only worried about 2 things:
I know about Derby issues. This is why I wrote "or similar". It would be good to have some, very simple and lightweight SQL database which could replace XMLRepository but it would not require that much effort to maintain. |
|
Artur Hefczyc wrote:
IMHO this is mostly for the unit-test purposes so whoever is writing tests (and thus utilising it) will be aware of the risk.
Bringing it up-to-speed with data-source was 2,5h (and it was needed only due to data-source introduction). Dealing with Derby weird issues (vide current problems) takes waaaay more time…
Possibly mentioned hsqldb could be such solution - it offers standard SP hence possibly less problematic support. Should we close this issue (as it's done) and create new one to investigate replacement of Derby with hsqldb? |
|
Your explanations Wojciech make sense and I agree with them. I am closing the ticket. |
Type |
Task
|
Priority |
Normal
|
Assignee | |
RedmineID |
4877
|
Version |
tigase-server-8.0.0
|
Spent time |
15h
|
Currently when there is no dataSource configured it should fallback to either dummy repository or, better yet, XMLRepository:
in case of
setup
we won't face exceptions related to repository;it could serve as a super basic storage to run super simple test (most likely better than Derby)