Projects tigase _server server-core Issues #644
Win-stuff folder cleanup (#644)
Closed
Daniel Wisnewski opened 9 years ago
Due Date
2016-02-28

Since we are moving away from an exe/jar installer, and dist-max is the recommended option, we should change the win-stuff folder structure to allow for a single copy into the main install directory for ease of installation on a windows system.

Suggested new structure

win-stuff/

InstallTigaseService.bat

Run.bat

Tigase.bat

Tigase.ico

UninstallTigaseService.bat

wrapper.conf

wrapper.exe

wrapper-community-license-1.2.txt

win-stuff/jars

wrapper.dll

wrapper.jar

There are also Tigase.iss and Tigase-minimal.iss which are not needed for an archival install. Uninst may also be removed from the archive as it is duplicated by UninstallTigaseService.bat and performs the same function.

Wojciech can you review before I commit changes?

3937_patch.diff

wojciech.kapcia@tigase.net commented 9 years ago

While it's true that we are phasing out our izpack installer I think that explicitly breaking it is not such a good idea. Instead of modifying existing directory structure (which would entail modifying again izpack to accommodate those) it would be better to modify web based installer to move those files accordingly if the setup is performed under Windows - what do you thing %andrzej.wojcik ?

Daniel Wisnewski commented 9 years ago

Proposed changes included in attached patch.

Andrzej Wójcik (Tigase) commented 9 years ago

Well, this could be done by web installer, however I do not think this is what you want, as web installer is available after you start Tigase XMPP Server, while this are scripts to start Tigase XMPP Server, so I think this move needs to be done before Tigase XMPP Server is started and before web installer will be able to do anything.

I would rather suggest to add new file to win-stuff@, ie. @install.bat or run.bat which will do this move and maybe later call actual Run.bat file?

However I agree that it would be better to leave directory structure in repository as it is now.

wojciech.kapcia@tigase.net commented 9 years ago

I concur Andrzej's comment, especially given that this would be a solution to make things more convenient:

we should change the win-stuff folder structure to allow for a single copy into the main install directory for ease of installation on a windows system.

Thus additional bat would help organise the structure while still being a one click solution.

Daniel Wisnewski commented 9 years ago

I've added the batch file, using relative paths it can be run from the win-stuff folder, making it a one-click solution as suggested. Will double-check latest build to ensure proper working order after compile.

Daniel Wisnewski commented 9 years ago

Setup file works OK after compilation. Adding a new subtask to change documentation to use the setup for windows.

issue 1 of 1
Type
Task
Priority
Normal
Assignee
RedmineID
3937
Version
tigase-server-7.1.0
Spent time
2h 30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#644
Please wait...
Page is in error, reload to recover