server STREAM attribute is missing.. (#64)

Steffen Larsen opened 1 decade ago

According to : http://xmpp.org/rfcs/rfc6120.html#streams-attr-version

The receiving entity MUST set the value of the 'version' attribute in the response stream header to either the value supplied by the initiating entity or the highest version number supported by the receiving entity, whichever is lower. The receiving entity MUST perform a numeric comparison on the major and minor version numbers, not a string match on ".".

I've created a small patch that put the version='1.0' attribute on the server stream tag.

Activities

Artur Hefczyc commented 1 decade ago

Thank you for the patch. However this class is no longer in use and is kept only for backward compatibility for deployments which rely on the old s2s implementation. A new s2s implementation with TLS and ZLib compression support has been created in class S2SConnectionManager and supporting classes.

Server version should be set properly in the new implementation.
Steffen Larsen commented 1 decade ago

I see, no problem. I've checked the other classes and they look fine with the version attribute, but what about making a private static final String STREAM_ATTR_VERSION = "1.0"; instead of making a string in each of the classes (its 10 classes or more). That would be more maintainable.
Artur Hefczyc commented 1 decade ago

True, indeed but according to the spec, there should be no predefined string actually, instead the version attribute should be calculated based on the version supported by both sides of the stream (on TODO now).
Steffen Larsen commented 1 decade ago

yes thats true. We should set it according to the initiating party (c2s or s2s).. and if not set at all, set it to 1.0.

Shall we make a new issue or shall I fix it on this current issue?
Login to comment

Type	Bug
Priority	Normal
Assignee	Steffen Larsen
RedmineID	179
Version	tigase-server-5.1.0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#64