Block Command (#608)

Behnam Hatami opened 10 years ago

Due Date
2015-12-17

There is a bug in new blocking command implementation, I think you should add null pointer checking in block code.

DATA=<iq xmlns="jabber:client" type="set" id="ZyaD2-295" from="pz1nfg8ryes3@test.com/ba1dd717b6ef5a26"><block xmlns="urn:xmpp:blocking"><item jid="uiojmvb4c187@test.com"/></block></iq>, SIZE=195, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=AUTH, TYPE=set
java.lang.NullPointerException
	at java.util.Collections.sort(Collections.java:175)
	at tigase.xmpp.impl.Privacy.block(Privacy.java:448)
	at tigase.xmpp.impl.BlockingCommand.processSetBlock(BlockingCommand.java:152)
	at tigase.xmpp.impl.BlockingCommand.process(BlockingCommand.java:111)
	at tigase.server.xmppsession.SessionManager$ProcessorWorkerThread.process(SessionManager.java:2526)
	at tigase.util.WorkerThread.run(WorkerThread.java:128)

Activities

Behnam Hatami commented 10 years ago

There is same problem in unblock and unblockAll functions in Privacy.
Andrzej Wójcik (Tigase) commented 10 years ago

Fixed NPE - Added protection in case of empty privacy list
Artur Hefczyc commented 10 years ago

No feedback, I am assuming it is fixed now.
Behnam Hatami commented 10 years ago

yes, It is fixed now.

thanks
Login to comment

Type	Bug
Priority	Major
Assignee	Behnam Hatami
RedmineID	3753
Version	tigase-server-7.1.0
Spent time	0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#608