Projects tigase _server server-core Issues #529
Separate plugin responsible for handling initial presence (#529)
Closed
wojciech.kapcia@tigase.net opened 9 years ago
Due Date
2015-08-31

Split handling of initial presence to separate plugin

Artur Hefczyc commented 9 years ago

Andrzej, this is similar to the other task for splitting presence plugin to have separate plugin for processing presence subscriptions and all other presences. It might be duplicate. Please confirm, otherwise provide work effort estimations.

Andrzej Wójcik (Tigase) commented 9 years ago

This is similar to #812 however I'm not sure if this is the same. In #3327 we want to split initial presence processing but in #812 we want to spit presences from presence subscriptions.

I set estimated time for this task.

Artur Hefczyc commented 9 years ago

Let's assume this is the same, because, technically all presences (non-subscription ones) are initial presences which do not require access to any permanent storage. Subscriptions do require because they update the roster, so let's split the plugin into 2 plugins, one which does access repository and another which do not require repository access.

Artur Hefczyc commented 9 years ago

Let's make it a low priority and work on it as the last thing before version closing. If we do not have enough time we can postpone it until next version.

Andrzej Wójcik (Tigase) commented 9 years ago

I separated initial presence handling from processing of subscription requests.

Now we have 2 processors (@PresenceState@ and @PresenceSubscription@) and one common base abstract processor (@PresenceAbstract@).

I changed config to use new processors but old processor (@Presence@) is still available but marked as @Deprecated

Artur Hefczyc commented 9 years ago

Andrzej, if all our automates tests (TTS) pass on this code, you can close the ticket.

Andrzej Wójcik (Tigase) commented 9 years ago

Looking at TTS results it is not possible to say if this works as it looks like TTS is failing for a longer while - probably due to changes in adhocs and now TTS is running only for 7.2.0-SNAPSHOT - which do not work correctly at this point.

wojciech.kapcia@tigase.net commented 9 years ago

%andrzej.wojcik I've switched builds to release branch so it should be possible to get at least some idea. Right now following seem to fail consistently (apart from ad-hocs),

Basic 7 (bosh),
Basic 9 (bosh),
Basic 7 (bosh-keep-alive),
Basic 9 (bosh-keep-alive),
Packet Order 2 (bosh-keep-alive),

but I don't think they are related to this issue.

Artur Hefczyc commented 9 years ago

In such a case, Andrzej, please close the ticket when all tests related are OK.

Andrzej Wójcik (Tigase) commented 9 years ago

I checked TTS results, custom tests and executed some additional tests on my own which confirmed that this works ok, so I'm closing this task.

issue 1 of 1
Type
New Feature
Priority
Minor
Assignee
RedmineID
3327
Version
tigase-server-7.1.0
Estimation
20h
Spent time
72h
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#529
Please wait...
Page is in error, reload to recover