Projects tigase _server server-core Issues #528
XEP-0172: User Nickname (#528)
Behnam Hatami opened 9 years ago
Due Date
2015-08-31

Hi,

As tigase server feature page [[http://tigase.net/server-features]] mentioned, it support nickname extension, bug it doesn't work!

I use nick name when I request a subscribe to other person, but tigase server doesn't use this name when adding that person to my roster and doesn't send this nickname to the recipient.

this is sample packet we send to server.

<presence from='narrator@moby-dick.lit' to='starbuck@moby-dick.lit' type='subscribe'>
  <nick xmlns='http://jabber.org/protocol/nick'>Ishmael</nick>
</presence>

Presence.java

Artur Hefczyc commented 9 years ago

Thank you for reporting the problem. We will look at it as soon as possible.

Behnam Hatami commented 9 years ago

Hi,

I modified the Presence plug-in to handle nickname in subscription.

Source Code Disclaimer: Yes;

Artur Hefczyc commented 9 years ago

What is status of the ticket? If not completed, provide work estimates.

wojciech.kapcia@tigase.net commented 9 years ago

I've verified the report and my conclusion is that the patch is not applicable and thus I would reject the submission.

XEP-0172: User Nickname defines a protocol for signalling user preferred nickname to the contact, but (in terms of including <nick/> payload in <message/> ore @presence@) doesn't define handling of such. From the specification it looks like it's more of a client-side signalling protocol and receiving contact client should display such suggested nickname to the contact but it's to the contact (to whom we've send the packet) to define the handle for the roster item. This would be consistent with the general idea in XMPP should not modify other entity roster (similar to presence sub: "server should not add any contact on user behalf without user confirmation").

Behnam Hatami commented 9 years ago

Hi,

you are right, but there is a problem here, server does not send this nickname to the receiver of the subscription request, which means nickname will be ignored.

wojciech.kapcia@tigase.net commented 9 years ago

I've just tested it and complete stanza is being delivered to the client.

S:

<presence  to='tigase_1@atlantiscity' type='subscribe'>
  <nick xmlns='http://jabber.org/protocol/nick'>Ishmael</nick>
</presence>

R:

<presence from="admin@atlantiscity" type="subscribe" to="tigase_1@atlantiscity">
<nick xmlns="http://jabber.org/protocol/nick">Ishmael</nick>
</presence>

Tigase doesn't strip Presence stanza.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
3314
Version
tigase-server-7.1.0
Spent time
6h
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#528
Please wait...
Page is in error, reload to recover