-
I implemented support for:
-
setting global list of
trusted
using--trusted
setting -
setting per component list of
trusted
usingtrusted
setting in component configuration
In each of this setting as entry which should be trusted it may be passed jid which may include
{clusterNode}
variable in it, which will force server to add this entry for each of cluster node, ie. if trusted would be set like this:--trusted=trusted@example.com,http@{clusterNode}
and we would have 2 cluster nodes
test1
andtest2
this will be same as setting:--trusted=trusted@example.com,http@test1,http@test2
If another cluster node will connect then property will be updated for this newly added node.
--trusted
is also used to set list of default trusted jids for VHosts, but in this case entries with{clusterNode}
will be skipped as this should not be used to set permission on per VHosts basis but on installation or per component basis.However this change required me to implement
ClusteredComponentIfc
inBasicComponent
as I needed info about every connected/disconnected node on this level. This was needed by the fact that I need to update set oftrusted jids
when . I updated all existing implementations ofClusteredComponentIfc
to call methods from super class to make this work properly.Now looking at currect implementation of methods
nodeConnected
and @nodeDisconnected@, I think that in most cases they have very similar implementation in almost every clustered component and similar to current implementation in @BasicComponent@. We could use this and refactor our code so that we would have one implementation of this methods if possible. This is thing to consider. -
-
I've updated PubSub ad-hocs to use changed code and now it works as expected.
Another issue I've encountered - if there's no script then there is no response to the sending entity - I think returning item-not-found in that case -- %kobit , do you agree?
Now looking at currect implementation of methods
nodeConnected
and @nodeDisconnected@, I think that in most cases they have very similar implementation in almost every clustered component and similar to current implementation in @BasicComponent@. We could use this and refactor our code so that we would have one implementation of this methods if possible. This is thing to consider.I think this is a good idea - would definitely simplify the implementation.
-
Actually - TTS test fails (repo reloading): http://build.tigase.org/nightlies/tests/files/static/tests/7.1.0-SNAPSHOT-b3973/func/pgsql/functional-tests.html after latest changes.
Type |
New Feature
|
Priority |
Normal
|
Assignee | |
RedmineID |
3244
|
Version |
tigase-server-7.1.0
|
Estimation |
0
|
Spent time |
0
|
Add option that will append list of all/chosen components addresses within cluster to the
trusted
list, as to avoid manual modification of configuration file, as per:https://projects.tigase.org/projects/tigase-pubsub/wiki/REST_API