NPE on SessionManager (#516)

Closed

Activities

Daniele Ricci opened 9 years ago

Another NPE, introduced with a recent change about SSL.

2015-06-03 21:53:05.189 [ConnectionOpenThread]  SocketThread.<clinit>()       WARNING:  5 socketWriteThreads started.
2015-06-03 21:53:25.714 [in_8-sess-man]    AbstractMessageReceiver$QueueListener.run()  SEVERE: [in_8-sess-man] Exception during packet processing: from=null, to=null, DATA=<iq from="c2s@beta.kontalk.net/178.62.44.19_5999_31.4.217.93_11868" to="sess-man@beta.kontalk.net" type="get" id="ssl_13b7ff78-4407-41e9-a6d5-7ee290c1d562"><command node="GETFEATURES" xmlns="http://jabber.org/protocol/commands"/></iq>, SIZE=234, XMLNS=null, PRIORITY=HIGH, PERMISSION=NONE, TYPE=get
java.lang.NullPointerException
        at tigase.server.xmppsession.SessionManager.processCommand(SessionManager.java:1324)
        at tigase.server.xmppsession.SessionManager.processPacket(SessionManager.java:503)
        at tigase.server.AbstractMessageReceiver$QueueListener.run(AbstractMessageReceiver.java:1424)

Like all the others switch cases, connection should be checked against null.

wojciech.kapcia@tigase.net commented 9 years ago

Applied in changeset commit:tigase-server|370e8e36.

Type	Bug
Priority	Normal
Assignee	Artur Hefczyc
RedmineID	3166

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#516