Projects tigase _server server-core Issues #510
RFC-6121, Section 4.3.2 - Server Processing of Inbound Presence Probe (#510)
Closed
Artur Hefczyc opened 9 years ago
Due Date
2015-06-29

There is a "small print" optional processing for the presence probe:

bq. However, if a server receives a presence probe from a configured domain of the server itself or another such trusted service, it MAY provide presence information about the user to that entity.

I think the best approach to this would be to make it configurable on the domain level, with a field to provide a list of such trusted entities to which presence information is provided.

This task is on request from the forums: message#5036

Andrzej Wójcik (Tigase) commented 9 years ago

%kobit As for:

I think the best approach to this would be to make it configurable on the domain level, with a field to provide a list of such trusted entities to which presence information is provided.

trusted entities - you mean list domains or even only list of jids allowed to use presence probe for this?

Artur Hefczyc commented 9 years ago

Yes, even a list of JIDs allowed to use presence probe. It might be useful when using components.

Andrzej Wójcik (Tigase) commented 9 years ago

I added this feature to support presence probe from users which jids are listed in VHostItem in Trusted JIDs section of vhost configuration for domain of recipient of presence probe.

In Trusted JIDs can be listed:

  • full jids - to allow only full jids to request presence probes

  • bare jids - to allow particular jids to request presence probes

  • domains - to alllow any user from listed domain to request presence probes

wojciech.kapcia@tigase.net commented 9 years ago

It looks like the property is not correctly applied from init.properties configuration (v. https://projects.tigase.org/boards/15/topics/5275?r=5329).

%kobit a question regarding the functionality -- should items from --trusted configuration be also included in the list while processing? (i.e. option to have global configuration option)?

Artur Hefczyc commented 9 years ago

I think the --trusted should be applied in a similar way to other this kind of options. It is a global setting which can be changed on a local level.

Andrzej Wójcik (Tigase) commented 9 years ago

I added test to confirm that trusted-jids is set properly from property from init.properties file.

I not added support for --trusted property/system setting as I do not get how it should work - if it should be set to VHostItem when vhost is added? when instance is created? or when exactly. Could you add this support of explain how it should work?

wojciech.kapcia@tigase.net commented 9 years ago

Andrzej Wójcik wrote:

I not added support for --trusted property/system setting as I do not get how it should work - if it should be set to VHostItem when vhost is added? when instance is created? or when exactly. Could you add this support of explain how it should work?

I was thinking about something similar to [--vhost-tls-required](http://docs.tigase.org/tigase-server/snapshot/Properties_Guide/html_chunk/vhostTlsRequired.html)

Andrzej Wójcik (Tigase) commented 9 years ago

With on/off setting it is easy as this setting is used if setting is not set for VHostItem, should this work in same way? So global setting would be only used if vhost setting would be not set at all?

Or maybe I should always add list of jids from global settings to list of jids from VHostItem?

Or maybe I should add list of jids from global settings only when vhost item is created?

For now I will implement it in way you described it - I will use list of global jids only if list of trusted jids from VHostItem is empty. Please check this is ok.

wojciech.kapcia@tigase.net commented 9 years ago

Andrzej Wójcik wrote:

For now I will implement it in way you described it - I will use list of global jids only if list of trusted jids from VHostItem is empty. Please check this is ok.

I think that this approach is best.

issue 1 of 1
Type
Task
Priority
Normal
Assignee
RedmineID
3135
Version
tigase-server-7.1.0
Spent time
43h 30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#510
Please wait...
Page is in error, reload to recover